Closed Bug 1267354 Opened 8 years ago Closed 5 years ago

[PageAction] Add support for chrome.pageAction.setIcon on Android

Categories

(WebExtensions :: Android, defect, P3)

Unspecified
Android
defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1530402
webextensions ?

People

(Reporter: mattw, Unassigned)

References

Details

(Whiteboard: [pageAction]triaged)

This bug is meant to track the implementation and testing of Chrome.pageAction.setIcon on android.

Firefox docs: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/PageAction/setIcon
Chrome docs: https://developer.chrome.com/extensions/pageAction#method-setIcon

Notes: There isn't an existing method in the PageActions.jsm module that we can wrap, but we should be able to add one by doing the following:
 - Add a new method to PageActions.jsm for setting the icon, which uses `Messaging.sendRequest(...)` to send a new message, maybe "PageActions:UpdateIcon" with the id of the PageAction returned by `PageActions.add(...)`.
 - Add a new case to handleUiMessage in PageActionLayout.java which updates the icon when the "PageActions:UpdateIcon" message is received.
Whiteboard: triaged → [pageAction]triaged
Assignee: nobody → mwein
This change will be a part of https://bugzilla.mozilla.org/show_bug.cgi?id=1270742.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WONTFIX
Reopening as it didn't actually end up being a part of bug 1270742.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Component: WebExtensions: Untriaged → WebExtensions: Android
Priority: -- → P3
webextensions: --- → ?
Assignee: matthewjwein → lgreco
Product: Toolkit → WebExtensions
Assignee: lgreco → nobody

Support for this was added in Bug 1530402.

Status: REOPENED → RESOLVED
Closed: 8 years ago5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.