GeckoView support for {Page,Browser}Action web-extension API
Categories
(GeckoView :: Extensions, enhancement, P1)
Tracking
(firefox70 wontfix, firefox71 wontfix, firefox72 fixed)
People
(Reporter: mbrubeck, Assigned: agi)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [geckoview:m1910] [geckoview:m1911])
Attachments
(12 files, 10 obsolete files)
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details | |
(deleted),
text/x-phabricator-request
|
Details |
Add support in GeckoView for the pageAction
API to dynamically display clickable icons and popups in the URL bar:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/pageAction
(The UI for this should be implemented by the Android Components toolbar.)
Comment 1•6 years ago
|
||
And we shouldn't forget the lessons from bug 1414084 for that, i.e. the component that keeps track of which page actions etc. are currently existing needs to match the lifetime of webextensions (and therefore Gecko) themselves.
Comment 2•6 years ago
|
||
I assume for Reader View in Fenix (blocked issue) we could rely on the messaging API (bug 1518843) and wouldn't need the generic page action API just yet?
Updated•6 years ago
|
Comment 3•6 years ago
|
||
Matt, how much work is the PageAction API? Can we defer this bug until after Fenix MVP? IIUC, WebExtension messaging support (bug 1518843) should be adequate for A-C to implement their Reader View WebExtension.
Comment 4•6 years ago
|
||
Matt says we don't need the PageAction API for Fenix MVP.
Reporter | ||
Updated•6 years ago
|
Updated•5 years ago
|
Comment 5•5 years ago
|
||
I'm editing a bunch of GeckoView bugs. If you'd like to filter all this bugmail, search and destroy emails containing this UUID:
e88a5094-0fc0-4b7c-b7c5-aef00a11dbc9
Assignee | ||
Comment 6•5 years ago
|
||
Looks like we want to work on this soon, so I'm resetting priority to discuss it during triage.
Assignee | ||
Comment 7•5 years ago
|
||
Design doc: https://docs.google.com/document/d/1XJuKk9Hm_2RNbX8KRcyUOXTaELBWYMyXBUchz15OElY/edit?usp=sharing
Morphing into page and browser actions since they are very similar.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Priority P2 + Rank 1 because Agi is working on it now for Fenix Q4.
Comment 9•5 years ago
|
||
Adding [geckoview:m1910]
whiteboard tag because Agi says he will probably have this work completed in October.
Assignee | ||
Comment 10•5 years ago
|
||
Mass moving bugs to the Extension component.
Comment 11•5 years ago
|
||
We want to work on this in October.
Assignee | ||
Comment 12•5 years ago
|
||
This patch refactors Desktop's implementation of Page and Browser actions to
decouple the logic inside a common Action object that can be used to implement
actions on other platforms, like mobile, without re-implementing it.
A follow-up commit will use this common logic on the mobile implementation.
Assignee | ||
Comment 13•5 years ago
|
||
This method allows consumers to decode images from a |nsIChannel| instance.
This method also supports vector images (e.g. SVGs), which other decode methods don't.
Assignee | ||
Comment 14•5 years ago
|
||
This class allows GeckoView embedders to decode images using Gecko's image
library.
Assignee | ||
Comment 15•5 years ago
|
||
This patch adds popup.xul which is identical to geckoview.xul but with a
different |windowtype|. This allows embedders to create "popup" windows that
are not visible to addons, e.g. for browser action popups.
Assignee | ||
Comment 16•5 years ago
|
||
This allows embedders to display two GeckoView on top of each other by setting
setZOrderOnTop on one of them.
TODO: figure out a better API for this that does not depend so much on
SurfaceTexture. Maybe we can set setZOrderOnTop when "popup" mode is enabled?
Assignee | ||
Comment 17•5 years ago
|
||
Assignee | ||
Comment 18•5 years ago
|
||
Assignee | ||
Comment 19•5 years ago
|
||
Comment 20•5 years ago
|
||
Rolling over to November sprint.
Assignee | ||
Comment 21•5 years ago
|
||
Assignee | ||
Comment 22•5 years ago
|
||
Assignee | ||
Comment 23•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 24•5 years ago
|
||
Assignee | ||
Comment 25•5 years ago
|
||
Assignee | ||
Comment 26•5 years ago
|
||
We're going to replace this implementation from scratch so we remove it here to
avoid a confusing diff.
Assignee | ||
Comment 27•5 years ago
|
||
Assignee | ||
Comment 28•5 years ago
|
||
Assignee | ||
Comment 29•5 years ago
|
||
Assignee | ||
Comment 30•5 years ago
|
||
We're going to replace this implementation from scratch so we remove it here to
avoid a confusing diff.
Assignee | ||
Comment 31•5 years ago
|
||
Assignee | ||
Comment 32•5 years ago
|
||
This matches desktop's TabTracker. Also, remove Tab:Selected which is an event
that was coming from Fennec.
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 33•5 years ago
|
||
Comment 34•5 years ago
|
||
Comment 35•5 years ago
|
||
Backed out for multiple failures e.g. columnrule-linestyles.html and test_composite.html.
backout: https://hg.mozilla.org/integration/autoland/rev/8f3cbd66bbc316a8ec8b38d85702d7c57e930f6c
failure log E.G.:
- REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/reftests/columns/columnrule-linestyles.html != http://10.0.2.2:8854/tests/layout/reftests/columns/columnrule-linestyles-notref.html | image comparison, max difference: 0, number of differing pixels: 0 https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276102129&repo=autoland&lineNumber=2121
- TEST-UNEXPECTED-FAIL | dom/tests/mochitest/general/test_bug1012662_editor.html | Timed out while polling clipboard for pasted data, got: --> Run Tests <-- https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276102131&repo=autoland&lineNumber=3857
- TEST-UNEXPECTED-FAIL | dom/animation/test/style/test_composite.html | Accumulate onto the base value - Accumulate onto the base value: assert_regexp_match: Actual value should be a matrix expected object "/^matrix((.+),(.+),(.+),(.+),(.+),(.+))/" but got "" https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276102124&repo=autoland&lineNumber=2742
Comment 36•5 years ago
|
||
Assignee | ||
Comment 37•5 years ago
|
||
Comment 38•5 years ago
|
||
Backed out for failing mochitest at test_ext_tabs_query.html
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=android%2C7.0%2Cmochitest-e10s-4%2Cm%284%29&revision=aa9499a196e3aca565d76ad4a65f16ef9377f3d0&selectedJob=276348518
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=276348518&repo=autoland&lineNumber=5480
Comment 39•5 years ago
|
||
Updated•5 years ago
|
Comment 40•5 years ago
|
||
Comment 41•5 years ago
|
||
Comment 42•5 years ago
|
||
Comment 43•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/eb9eb64782b9
https://hg.mozilla.org/mozilla-central/rev/6d66e846ad46
https://hg.mozilla.org/mozilla-central/rev/48cd0a34cab7
https://hg.mozilla.org/mozilla-central/rev/ebce35d83c87
https://hg.mozilla.org/mozilla-central/rev/64fde5f3d49f
https://hg.mozilla.org/mozilla-central/rev/9afd2ad768ec
https://hg.mozilla.org/mozilla-central/rev/0fdc505ba2f6
https://hg.mozilla.org/mozilla-central/rev/13283dd2b5fd
https://hg.mozilla.org/mozilla-central/rev/787a3ae7f1b7
https://hg.mozilla.org/mozilla-central/rev/59fd566c80c7
https://hg.mozilla.org/mozilla-central/rev/10b03e28fe0d
https://hg.mozilla.org/mozilla-central/rev/7c966d8fdbc0
Updated•3 years ago
|
Description
•