Closed
Bug 1268333
Opened 9 years ago
Closed 8 years ago
Log parser should always ignore "ImportError: No module named pygtk"
Categories
(Tree Management :: Treeherder: Data Ingestion, defect)
Tree Management
Treeherder: Data Ingestion
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: philor, Assigned: jgraham)
References
Details
Attachments
(1 file)
No Linux64 debug tests ever get autoclassified, because they are run by taskcluster using scripts written for buildbot which import pygtk, which the taskcluster instances don't have, so every single test run has that pointless and meaningless line.
Comment 1•9 years ago
|
||
Whilst the auto-classifier does have its own blacklist of terms, it makes sense to blacklist this in the log parser in general.
In addition,
Blocks: 1241940
Component: Treeherder → Treeherder: Data Ingestion
Summary: Autoclassify should always ignore "ImportError: No module named pygtk" → Log parser should always ignore "ImportError: No module named pygtk"
Comment 2•9 years ago
|
||
(In reply to Ed Morley [:emorley] from comment #1)
> In addition,
...this should really also be fixed upstream, for which bug 1227652 is filed.
Updated•9 years ago
|
Assignee: nobody → james
Comment 3•9 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/6e9b10e3863da5dab84fae0e2d39e657138902d3
Bug 1268331, 1268333 - Improve blacklist of useless log lines
https://github.com/mozilla/treeherder/commit/e36e781e4b565d88256cb4790679455a58270f49
Merge pull request #1436 from mozilla/log_blacklist
Bug 1268331, 1268333 - Improve blacklist of useless log lines
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 4•8 years ago
|
||
Unfortunately this doesn't seem to be fixed.
Example:
1) try run on linux64 with mochitests [1]
2) Select tc-M bc3
3) Note the pygtk warning listed in the failures summary [2]
4) Go to the log in the log viewer, note the pygtk line is selected rather than real failures [3]
Also note if you look at one the suites that passed (say tc-M bc1 [4]) the line does show up in the failures summary, but the suite is considered passed.
[1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d406e66ce502d76cff1a812bb5557a791f8013b7
[2] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d406e66ce502d76cff1a812bb5557a791f8013b7&selectedJob=25434734
[3] https://treeherder.mozilla.org/logviewer.html#?job_id=25434734&repo=try
[4] https://treeherder.mozilla.org/#/jobs?repo=try&revision=d406e66ce502d76cff1a812bb5557a791f8013b7&selectedJob=25434712
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 5•8 years ago
|
||
Comment 6•8 years ago
|
||
Comment on attachment 8780248 [details]
[treeherder] wlach:1268333 > mozilla:master
This should really do it.
Attachment #8780248 -
Flags: review?(emorley)
Updated•8 years ago
|
Attachment #8780248 -
Flags: review?(emorley) → review+
Comment 7•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/600ff8bb8367f26b180de01cfe9f8afaeac41caf
Bug 1268333 - Ignore pygtk import lines properly (#1781)
Handle newlines after blacklisted strings and add unit tests for this case
Comment 8•8 years ago
|
||
I think we're good now.
Status: REOPENED → RESOLVED
Closed: 9 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•