Closed
Bug 1269157
Opened 9 years ago
Closed 9 years ago
Add "Document.fullscreen" as unprefixed version of Document.mozFullScreen
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla49
Tracking | Status | |
---|---|---|
firefox49 | --- | fixed |
People
(Reporter: xidorn, Assigned: xidorn)
References
Details
(Keywords: dev-doc-complete, Whiteboard: btpp-fixlater)
Attachments
(1 file)
We have document.mozFullScreen but there is no corresponding unprefixed property in the spec. And it seems lack of that property could cause webcompat issue. See https://github.com/whatwg/fullscreen/issues/38
Adding this property should be a trivial work. But given this is another new regression reported, we may really want to hold back unprefixing Fullscreen API then.
Comment 1•9 years ago
|
||
yes, sounds like we need to disable the unprefixed API
Updated•9 years ago
|
Whiteboard: btpp-fixlater
Assignee | ||
Comment 2•9 years ago
|
||
I've had a patch, but I'd like to hold until patches in bug 1269276 get reviewed first.
Assignee: nobody → bugzilla
Assignee | ||
Comment 3•9 years ago
|
||
Kohei, FYI, we are going to add document.fullscreen in this bug as the unprefixed equivalent of document.mozFullScreen. You may want to add this to your fxsitecompat article.
Comment 4•9 years ago
|
||
Thanks! Mentioned this bug in the site compat doc. https://www.fxsitecompat.com/en-CA/docs/2016/fullscreen-api-has-been-unprefixed-in-non-release-builds/
Assignee | ||
Comment 5•9 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/51829/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/51829/
Attachment #8751104 -
Flags: review?(bugs)
Comment 6•9 years ago
|
||
Comment on attachment 8751104 [details]
MozReview Request: Bug 1269157 - Add Document.fullscreen attribute. r?smaug
https://reviewboard.mozilla.org/r/51829/#review48897
Our webidl bindings are so great.
Attachment #8751104 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/a47ca5217c13181c46a9bb0ea7e868ed9130c5e8
Bug 1269157 - Add Document.fullscreen attribute. r=smaug
Comment 8•9 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla49
Updated•9 years ago
|
Keywords: dev-doc-needed
Comment 9•8 years ago
|
||
Created:
https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenchange
https://developer.mozilla.org/en-US/docs/Web/API/Document/onfullscreenerror
Updated:
https://developer.mozilla.org/en-US/Firefox/Releases/49#Others
https://developer.mozilla.org/en-US/docs/Web/API/Document
https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers
Keywords: dev-doc-needed → dev-doc-complete
Comment 11•8 years ago
|
||
This time it is done:
https://developer.mozilla.org/en-US/docs/Web/API/Document/fullscreen
and
https://developer.mozilla.org/en-US/Firefox/Releases/49#Others
Keywords: dev-doc-needed → dev-doc-complete
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•