Closed
Bug 1270705
Opened 8 years ago
Closed 8 years ago
[TV][Home] Cannot move card to folder through pressing OK key when folder enlarge to hold card inside
Categories
(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)
Tracking
(blocking-b2g:2.6+)
VERIFIED
FIXED
blocking-b2g | 2.6+ |
People
(Reporter: mlien, Assigned: Fischer)
References
Details
(Whiteboard: [ft:conndevices])
Attachments
(1 file)
[Description] According to the latest UX spec(https://drive.google.com/open?id=0BwbmH5cX2W6Od0EwMXpSWlFwcDQ), if moving card to overlap folder, folder will enlarge to hold card inside. In the meantime pressing OK key will add card to the first position of card list in folder [Testing Steps] 1. Add a new folder with any card 2. Navigate to any card in main list 3. Press Option key -> Choose Move 4. Move card to overlap step 1's folder 5. Press OK key [Expected result] Should add the card to first position of card list in folder [Actual result] No any function [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/18fc4607ca127805586803e9300927ae257f725a gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/ccf59a9dda868db58b5d943e2c4235ead89f9344
Updated•8 years ago
|
blocking-b2g: 2.6? → 2.6+
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → fliu
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8752028 [details]
[gaia] Fischer-L:bug_1270705-press-enter-should-insert-card-into-folder > mozilla-b2g:v2.6
@Luke,
This patch makes pressing Enter key the same as pressing Down key to insert card into folder, thanks
Attachment #8752028 -
Flags: review?(lchang)
Comment 3•8 years ago
|
||
Comment on attachment 8752028 [details]
[gaia] Fischer-L:bug_1270705-press-enter-should-insert-card-into-folder > mozilla-b2g:v2.6
According to the spec, we may need to alter it a bit.
Attachment #8752028 -
Flags: review?(lchang)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8752028 [details]
[gaia] Fischer-L:bug_1270705-press-enter-should-insert-card-into-folder > mozilla-b2g:v2.6
@Luke,
Update the patch so that after pressing Enter to move card into folder, the arrange mode would be toggled off, thanks.
Attachment #8752028 -
Flags: review?(lchang)
Comment 5•8 years ago
|
||
Comment on attachment 8752028 [details]
[gaia] Fischer-L:bug_1270705-press-enter-should-insert-card-into-folder > mozilla-b2g:v2.6
Looks good! Thanks.
Attachment #8752028 -
Flags: review?(lchang) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/242c9f2d188f884002895a24e8e52b59b9308f5e
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 7•8 years ago
|
||
verified and fixed with the latest build 2.6 simulator gaia: https://github.com/mozilla-b2g/gaia/commit/c5cceac45c13eab6a297074d55261610d8a0880f gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/425aaa9763aef80ec1f7e78079e410ee1ccc9e32
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•