Closed Bug 1275156 Opened 9 years ago Closed 9 years ago

[TV][Home] Pressing OK key when enlarged folder hold card inside be able to exceed upper bound number of cards

Categories

(Firefox OS Graveyard :: Gaia::TV::Home, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::TV::Home
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:2.6?)

Status:
VERIFIED FIXED
Project Flags:
blocking-b2g 2.6?

People

(Reporter: mlien, Assigned: Fischer)

References

Details

(Whiteboard: [ft:conndevices])

Attachments

(1 file)

[gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6
(deleted), text/x-github-pull-request
lchang
: review+
Details
[Testing Steps] 1. Add a new folder with 9 cards 2. Navigate to any card in main list 3. Press Option key -> Choose Move 4. Move card to overlap step 1's folder 5. Press OK key [Expected result] Should reject this card movement and show notification banner [Actual result] Card can be moved to this folder [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/5069e2af2d292be1b83475de3c3e0656e94f6395 gecko: https://github.com/mozilla-b2g/gecko-b2g/commit/9f233a9b2c912dc45021db56e215090e2b955975
Comment on attachment 8755734 [details] [gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6 @Luke, This patch checks the folder capacity before adding card into folder by pressing OK key, thanks
Attachment #8755734 - Flags: review?(lchang)
Comment on attachment 8755734 [details] [gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6 @Luke, This patch checks the folder capacity before adding card into folder by pressing OK key, thanks
Assignee: nobody → fliu
Comment on attachment 8755734 [details] [gaia] Fischer-L:bug_1275156-pressing-ok-to-add-card-into-folder-over-limit > mozilla-b2g:v2.6 Looks good!
Attachment #8755734 - Flags: review?(lchang)
Attachment #8755734 - Flags: review+
Land to v2.6: https://github.com/mozilla-b2g/gaia/commit/53f70ab0313250225210e966c7407ec828265895
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: