Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Description • 8 years ago

ATOK 2011 - ATOK 2015 refers native caret position at deciding the position of candidate window position, navibar position, etc. However, this is too bad because even if we need to lie TSF and/or TIP for some reasons (e.g., new Web API for IME), it's impossible.

ATOK must refer our window class name before using the caret hack, so, we should change our window class name locally and investigate what we need to do for supporting ATOK which doesn't use the hack.

I think that we need to fix this bug by the end of Aug or Sep.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 1 • 8 years ago

As far as investigated, ATOK 2016 works perfectly without any hacks for TS_E_NOLAYOUT!!!

ATOK 2011 has the problem, but ATOK 2012 works fine except NaviBar positioning. So, ATOK 2012 and ATOK 2013 must be added some hacks for TS_E_NOLAYOUT bug of TSF.

Probably, we can just disable native caret hack for current ATOK when ATOK 2017 or later is active.

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 2 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f962ff135e8c

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 3 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ca309a8292f

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 4 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e52ea4738923

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 5 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e0a4ecb5cb97

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 6 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=23e4b0ae1166

	Masayuki Nakano [:masayuki] (he/him)(JST, +0900) Assignee
	Comment 7 • 8 years ago

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dab908cbbb0

	Makoto Kato [:m_kato]
	Comment 11 • 8 years ago
mozreview-review

Comment on attachment 8781841 [details]
Bug 1273510 part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active

https://reviewboard.mozilla.org/r/72168/#review70508

	Makoto Kato [:m_kato]
	Comment 12 • 8 years ago
mozreview-review

Comment on attachment 8781842 [details]
Bug 1273510 part.2 Modify comment in IMMHandler::SetCandidateWindow()

https://reviewboard.mozilla.org/r/72170/#review70510

	Makoto Kato [:m_kato]
	Comment 13 • 8 years ago
mozreview-review

Comment on attachment 8781843 [details]
Bug 1273510 part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window

https://reviewboard.mozilla.org/r/72172/#review70512

	Pulsebot
	Comment 14 • 8 years ago

Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/48fc8ff49e8f
part.1 TSFTextStore should use native caret hack only when ATOK 2011 - 2016 is active r=m_kato
https://hg.mozilla.org/integration/autoland/rev/19217cab82c6
part.2 Modify comment in IMMHandler::SetCandidateWindow() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/060472436aa5
part.3 We should not return TS_E_NOLAYOUT when ATOK decides its suggest window r=m_kato

	Ryan VanderMeulen [:RyanVM]
	Comment 15 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/48fc8ff49e8f
https://hg.mozilla.org/mozilla-central/rev/19217cab82c6
https://hg.mozilla.org/mozilla-central/rev/060472436aa5