Closed
Bug 1293957
Opened 8 years ago
Closed 8 years ago
[TSF][TS_E_NOLAYOUT] Improve TSFTextStore::GetTextExt()
Categories
(Core :: Widget: Win32, defect, P4)
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
Details
(Keywords: inputmethod, Whiteboard: tpi:+)
Attachments
(3 files)
I find some bugs around TSFTextStore::GetTextExt(). I'll post some patches for them.
Updated•8 years ago
|
Priority: -- → P4
Whiteboard: tpi:+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•8 years ago
|
||
FYI: These patches fix some long standing bugs, e.g., you see MS-IME's or Google Japanese Input's suggest window is positioned at top-left of the screen or something and moved to the correct position immediately after that.
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8781336 [details]
Bug 1293957 part.1 TSFTextStore::Content::mMinTextModifiedOffset should be treated as the first offset of modified characters
https://reviewboard.mozilla.org/r/71750/#review69334
Attachment #8781336 -
Flags: review?(m_kato) → review+
Comment 6•8 years ago
|
||
mozreview-review |
Comment on attachment 8781337 [details]
Bug 1293957 part.2 TSFTextStore::GetTextExt() shouldn't return TS_E_NOLAYOUT after hacking the query range
https://reviewboard.mozilla.org/r/71752/#review69342
Attachment #8781337 -
Flags: review?(m_kato) → review+
Comment 7•8 years ago
|
||
mozreview-review |
Comment on attachment 8781338 [details]
Bug 1293957 part.3 TSFTextStore::GetTextExt() shouldn't query text rect with 0 length
https://reviewboard.mozilla.org/r/71754/#review69346
Attachment #8781338 -
Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/e75a8aa973d7
part.1 TSFTextStore::Content::mMinTextModifiedOffset should be treated as the first offset of modified characters r=m_kato
https://hg.mozilla.org/integration/autoland/rev/beb5314cb9d5
part.2 TSFTextStore::GetTextExt() shouldn't return TS_E_NOLAYOUT after hacking the query range r=m_kato
https://hg.mozilla.org/integration/autoland/rev/9fc367d8d8bc
part.3 TSFTextStore::GetTextExt() shouldn't query text rect with 0 length r=m_kato
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e75a8aa973d7
https://hg.mozilla.org/mozilla-central/rev/beb5314cb9d5
https://hg.mozilla.org/mozilla-central/rev/9fc367d8d8bc
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Assignee | ||
Updated•6 years ago
|
Summary: [TSF] Improve TSFTextStore::GetTextExt() → [TSF][TS_E_NOLAYOUT] Improve TSFTextStore::GetTextExt()
You need to log in
before you can comment on or make changes to this bug.
Description
•