Closed Bug 1293957 Opened 8 years ago Closed 8 years ago

[TSF][TS_E_NOLAYOUT] Improve TSFTextStore::GetTextExt()

Categories

(Core :: Widget: Win32, defect, P4)

All
Windows
defect

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox51 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod, Whiteboard: tpi:+)

Attachments

(3 files)

I find some bugs around TSFTextStore::GetTextExt(). I'll post some patches for them.
Priority: -- → P4
Whiteboard: tpi:+
FYI: These patches fix some long standing bugs, e.g., you see MS-IME's or Google Japanese Input's suggest window is positioned at top-left of the screen or something and moved to the correct position immediately after that.
Comment on attachment 8781336 [details] Bug 1293957 part.1 TSFTextStore::Content::mMinTextModifiedOffset should be treated as the first offset of modified characters https://reviewboard.mozilla.org/r/71750/#review69334
Attachment #8781336 - Flags: review?(m_kato) → review+
Comment on attachment 8781337 [details] Bug 1293957 part.2 TSFTextStore::GetTextExt() shouldn't return TS_E_NOLAYOUT after hacking the query range https://reviewboard.mozilla.org/r/71752/#review69342
Attachment #8781337 - Flags: review?(m_kato) → review+
Comment on attachment 8781338 [details] Bug 1293957 part.3 TSFTextStore::GetTextExt() shouldn't query text rect with 0 length https://reviewboard.mozilla.org/r/71754/#review69346
Attachment #8781338 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/e75a8aa973d7 part.1 TSFTextStore::Content::mMinTextModifiedOffset should be treated as the first offset of modified characters r=m_kato https://hg.mozilla.org/integration/autoland/rev/beb5314cb9d5 part.2 TSFTextStore::GetTextExt() shouldn't return TS_E_NOLAYOUT after hacking the query range r=m_kato https://hg.mozilla.org/integration/autoland/rev/9fc367d8d8bc part.3 TSFTextStore::GetTextExt() shouldn't query text rect with 0 length r=m_kato
Summary: [TSF] Improve TSFTextStore::GetTextExt() → [TSF][TS_E_NOLAYOUT] Improve TSFTextStore::GetTextExt()
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: