Closed
Bug 1273823
Opened 8 years ago
Closed 8 years ago
Optimize CreateSourceSurfaceFromLockedMacIOSurface()
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla51
| Tracking | Status | |
|---|---|---|
| firefox51 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
(Blocks 1 open bug)
Details
(Keywords: feature)
Attachments
(1 file, 4 obsolete files)
|
(deleted),
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
By Bug 1230641 AppleVDADecoder output became UYVY (YUV422). It is converted to SurfaceFormat::B8G8R8X8 in CreateSourceSurfaceFromLockedMacIOSurface().
It seems not efficient enough.
https://dxr.mozilla.org/mozilla-central/source/gfx/layers/MacIOSurfaceHelpers.cpp#86
|
Assignee | |
Updated•8 years ago
|
Blocks: unaccel-video
|
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 1•8 years ago
|
||
|
|
Assignee | |
Comment 2•8 years ago
|
||
attachment 8753733 [details] [diff] [review] improved a performance. But the improvement seems not good enough. The approach of Bug 1254874 comment 2 might help.
|
|
Assignee | |
Updated•8 years ago
|
Summary: Add UYVY support to gfx/ycbcr → Optimize CreateSourceSurfaceFromLockedMacIOSurface()
|
|
Assignee | |
Comment 4•8 years ago
|
||
Attachment #8781471 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 5•8 years ago
|
||
Attachment #8787081 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•8 years ago
|
||
Attachment #8787082 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 7•8 years ago
|
||
The patch improved basic_compositor_video amd basic_compositor_video opt about 10% on mac.
https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=af0a7bff056dcf1ee79bb4bd99fbb159b00e4252&newProject=try&newRevision=58a685c055505d141cd5290f608bfb49eaf6773a&framework=1
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8787083 -
Flags: review?(jmuizelaar)
|
|
Assignee | |
Comment 8•8 years ago
|
||
Comment on attachment 8787083 [details] [diff] [review]
patch - Optimize CreateSourceSurfaceFromLockedMacIOSurface()
Change review request to :nical, since jeff is in PTO.
Attachment #8787083 -
Flags: review?(jmuizelaar) → review?(nical.bugzilla)
|
||
Updated•8 years ago
|
Attachment #8787083 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6acc0713f779
Optimize CreateSourceSurfaceFromLockedMacIOSurface() r=nical
|
||
Comment 10•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox51:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•