Closed
Bug 1275903
Opened 8 years ago
Closed 8 years ago
Add tests for the log slice API & switch to using requests
Categories
(Tree Management :: Treeherder: API, defect)
Tree Management
Treeherder: API
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: emorley, Assigned: wlach)
References
Details
Attachments
(1 file)
To help avoid eg bug 1275796.
|
||
Comment 2•8 years ago
|
||
|
Assignee | |
Comment 3•8 years ago
|
||
Comment on attachment 8756943 [details]
[treeherder] wlach:1275903 > mozilla:master
This doesn't cover everything, but should have caught the last few problems we ran into.
Bonus: it replaces some use of urllib2 with requests. :)
Attachment #8756943 -
Flags: review?(emorley)
|
Reporter | |
Comment 4•8 years ago
|
||
Comment on attachment 8756943 [details]
[treeherder] wlach:1275903 > mozilla:master
Thank you for this! Also great to remove more of urllib2 :-)
Attachment #8756943 -
Flags: review?(emorley) → review+
|
||
Comment 5•8 years ago
|
||
Commits pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/10e812dba1b7641a7860de0beec403110a688d0d
Bug 1275903 - Convert logslice API to use requests
https://github.com/mozilla/treeherder/commit/d84cfa0df8eb4c6e43b093a0903ec0d8511740dc
Bug 1275903 - Remove use of jobsmodel from logslice API
https://github.com/mozilla/treeherder/commit/eea4bdd0d1c1e0ec0a2102ebd52c46c99ffd9e06
Bug 1275903 - Add unit test for logslice API
https://github.com/mozilla/treeherder/commit/718cc359230d8d9ab6c02a76672b464ee86b5fd9
Merge pull request #1521 from wlach/1275903
Bug 1275903 - Add unit tests for logslice API
|
|
Assignee | |
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•8 years ago
|
Summary: Add tests for the log slice API → Add tests for the log slice API & switch to using requests
You need to log in
before you can comment on or make changes to this bug.
Description
•