Closed Bug 1276534 Opened 8 years ago Closed 8 years ago

The right arrow mark in a menu for indicating submenus disappears after selecting the menu

Categories

(Core :: Widget: Gtk, defect)

46 Branch
x86_64
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: euthanasia_waltz, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image screenshots (deleted) —
OS: manjaro-linux-xfce x86_64 GTK: gtk3 3.20.5-2 STR1: 1. Press ALT, click "Tools" menu 2. Move mouse pointer onto "Web Developer" 3. Move mouse pointer out of "Web Developer" ER: The right arrow on the right-end of "Web Developer" appears AR: the right arrow on the right-end of "Web Developer" does not appear STR2: 1. Press ALT, press T ("Downloads" is selected and "Web Developer" does not have a right arrow) STR3: 1. Press ALT, click "Tools" menu 2. Move mouse pointer onto "Downloads" 3. Slide mouse pointer on "Downloads"->"Tools"->"Bookmarks" ("Bookmarks" menus do not have right arrows)
Blocks: gtk3
Blocks: gtk-3.20
No longer blocks: gtk3
Component: Menus → Widget: Gtk
Product: Firefox → Core
I confirmed today's Linux x64 nightly build.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Confirming on FF50, gtk3.18 .
I haven't observed this with Adwaita 3.18.7, but WG9s and aceman are both reporting it on 3.18. Which GTK themes are you using with 3.18? Does it reproduce 100% of the time?
I don't know which GTK theme is really used as I am running under a user that has a KDE desktop. Is there an app for selecting gtk theme? But I have adwaita 3.18.0 installed.
That's also caused by gtk_style_context_save/gtk_style_context_restore in moz_gtk_menu_arrow_paint()
Attached patch patch (deleted) — Splinter Review
Removed the GTK_STYLE_CLASS_MENUITEM explicit set. We don't need that as it's added in gtk_menu_item_new() (more specifically in gtk_menu_item_init()) for version which needs that.
Attachment #8762515 - Flags: review?(karlt)
Attachment #8762515 - Flags: review?(karlt) → review+
(In reply to :aceman from comment #4) > I don't know which GTK theme is really used as I am running under a user > that has a KDE desktop. There are a number of ways to set the GTK theme, and they differ on different systems. I think the best way to determine which theme is in use is as follows: 1. Run "gsettings set org.gtk.Settings.Debug enable-inspector-keybinding true" 2. Start gtk3-widget-factory and focus the new window. 3. Type Ctrl-Shift-I, which should start a GTK inspector window. 4. In the new window, select the "Visual" tab. That will show the theme. This may be unnecessary now, with this patch, thanks. If the patch doesn't resolve the issue for you, then please file a new bug. "Clone this bug", if the steps to reproduce are the same.
(In reply to Karl Tomlinson (ni?:karlt) from comment #7) > 2. Start gtk3-widget-factory and focus the new window. Alternatively, open the file dialog from Firefox, but using the inspector from here is crashy, and so this is not recommended in a Firefox session you are using for other purposes.
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e05b52a20435 don't save/restore style context on arrows on menu, r=karlt
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Blocks: 1280227
This bug is marked as fixed, but the issue actually still occurs in 50.0a1 20160616020919. Using Ubuntu 16.04 (x64) with GNOME 3.20 (GTK 3.20) and the build from https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa Let me know if you need any more information.
(In reply to Age Bosma from comment #12) > This bug is marked as fixed, but the issue actually still occurs in 50.0a1 > 20160616020919. > > Using Ubuntu 16.04 (x64) with GNOME 3.20 (GTK 3.20) and the build from > https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa > > Let me know if you need any more information. For issues with versions of Firefox you load with Ubuntu customizations, please submit bugs via the Ubuntu bug filing mechanism. Bugs here are for official Mozilla versions only. The official Mozilla nightly builds are available at nightly.mozilla.org.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: