atlanto Reporter
	Description • 8 years ago

OS: manjaro-linux-xfce x86_64
GTK: gtk3 3.20.5-2

STR1:
1. Press ALT, click "Tools" menu
2. Move mouse pointer onto "Web Developer"
3. Move mouse pointer out of "Web Developer"

ER:
The right arrow on the right-end of "Web Developer" appears
AR:
the right arrow on the right-end of "Web Developer" does not appear

STR2:
1. Press ALT, press T
("Downloads" is selected and "Web Developer" does not have a right arrow)

STR3:
1. Press ALT, click "Tools" menu
2. Move mouse pointer onto "Downloads"
3. Slide mouse pointer on "Downloads"->"Tools"->"Bookmarks"
("Bookmarks" menus do not have right arrows)

	Hideo Oshima
	Comment 1 • 8 years ago

I confirmed today's Linux x64 nightly build.

	:aceman
	Comment 2 • 8 years ago

Confirming on FF50, gtk3.18 .

	Karl Tomlinson (:karlt)
	Comment 3 • 8 years ago

I haven't observed this with Adwaita 3.18.7, but WG9s and aceman are both reporting it on 3.18.

Which GTK themes are you using with 3.18?
Does it reproduce 100% of the time?

	:aceman
	Comment 4 • 8 years ago

I don't know which GTK theme is really used as I am running under a user that has a KDE desktop.
Is there an app for selecting gtk theme?
But I have adwaita 3.18.0 installed.

	Martin Stránský [:stransky] (ni? me)
	Comment 5 • 8 years ago

That's also caused by gtk_style_context_save/gtk_style_context_restore in moz_gtk_menu_arrow_paint()

	Martin Stránský [:stransky] (ni? me)
	Comment 6 • 8 years ago

Removed the GTK_STYLE_CLASS_MENUITEM explicit set. We don't need that as it's added in gtk_menu_item_new() (more specifically in gtk_menu_item_init()) for version which needs that.

	Karl Tomlinson (:karlt)
	Comment 7 • 8 years ago

(In reply to :aceman from comment #4)
> I don't know which GTK theme is really used as I am running under a user
> that has a KDE desktop.

There are a number of ways to set the GTK theme, and they differ on different systems.
I think the best way to determine which theme is in use is as follows:

1. Run "gsettings set org.gtk.Settings.Debug enable-inspector-keybinding true"
2. Start gtk3-widget-factory and focus the new window.
3. Type Ctrl-Shift-I, which should start a GTK inspector window.
4. In the new window, select the "Visual" tab.  That will show the theme.

This may be unnecessary now, with this patch, thanks.
If the patch doesn't resolve the issue for you, then please file a new bug.
"Clone this bug", if the steps to reproduce are the same.

	Karl Tomlinson (:karlt)
	Comment 8 • 8 years ago

(In reply to Karl Tomlinson (ni?:karlt) from comment #7)
> 2. Start gtk3-widget-factory and focus the new window.

Alternatively, open the file dialog from Firefox, but using the inspector from here is crashy, and so this is not recommended in a Firefox session you are using for other purposes.

	Martin Stránský [:stransky] (ni? me)
	Comment 9 • 8 years ago

Comment on attachment 8762515 [details] [diff] [review]
patch

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b198329e511e

	Pulsebot
	Comment 10 • 8 years ago

Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e05b52a20435
don't save/restore style context on arrows on menu, r=karlt

	Carsten Book [:Tomcat]
	Comment 11 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/e05b52a20435

	Age Bosma
	Comment 12 • 8 years ago

This bug is marked as fixed, but the issue actually still occurs in 50.0a1 20160616020919.

Using Ubuntu 16.04 (x64) with GNOME 3.20 (GTK 3.20) and the build from https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa

Let me know if you need any more information.

	Bill Gianopoulos [:WG9s]
	Comment 13 • 8 years ago

(In reply to Age Bosma from comment #12)
> This bug is marked as fixed, but the issue actually still occurs in 50.0a1
> 20160616020919.
> 
> Using Ubuntu 16.04 (x64) with GNOME 3.20 (GTK 3.20) and the build from
> https://launchpad.net/~ubuntu-mozilla-daily/+archive/ubuntu/ppa
> 
> Let me know if you need any more information.

For issues with versions of Firefox you load with Ubuntu customizations, please submit bugs via the Ubuntu bug filing mechanism.  Bugs here are for official Mozilla versions only.  The official Mozilla nightly builds are available at nightly.mozilla.org.