Closed Bug 1277437 Opened 8 years ago Closed 6 years ago

[webvtt] Process cue and apply related CSS attributes on the div element

Categories

(Core :: Audio/Video: Playback, defect, P2)

Product:
Core
Component:
Audio/Video: Playback
Version:
Other Branch
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla67
Tracking Flags:
Tracking Status
firefox67 --- fixed

People

(Reporter: alwu, Assigned: alwu)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

Bug 1277437 - part1 : remove UA agent checkings.
(deleted), text/x-phabricator-request
Details
Bug 1277437 - part2 : make CueStyleBox class-based.
(deleted), text/x-phabricator-request
Details
Bug 1277437 - part3 : apply WebVTT cue settings.
(deleted), text/x-phabricator-request
Details
Bug 1277437 - part4 : change font size internally in CueStyleBox.
(deleted), text/x-phabricator-request
Details
Bug 1277437 - part5 : apply default style on cue when we don't use pseudo element.
(deleted), text/x-phabricator-request
Details
https://w3c.github.io/webvtt/#apply-webvtt-cue-settings Follow the step1~step8 in the spec.
Mass change P2 -> P3
Priority: P2 → P3
Priority: P3 → P5
Blocks: 1305732
Blocks: 1353689
Assignee: alastor0325 → nobody
Assignee: nobody → alwu
Priority: P5 → P2

There is no need to check whether the code is running on other browser, because we won't upstream the change back to the github repo, as this code uses a lots mozilla-only APIs.

Using class syntax for CueStyleBox made us easier to simplify the code and make it more readable.

Follow the spec 7.2 and 7.4 to process cue and apply css setting for the div element.

Summary: [webvtt] modify the formula about computing CSS property in "apply WebVTT cue settings" → [webvtt] Processing cue and apply related CSS attributes on the div element
Summary: [webvtt] Processing cue and apply related CSS attributes on the div element → [webvtt] Process cue and apply related CSS attributes on the div element

CueStyleBox should handle all css attributes, so it make more sense to adjust font size and style inside CueStyleBox.

If cue div is not a pseudo element, which means we don't have a default style applying on it. Therefore, we should set the default css style for it.

Blocks: 1488673
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/797abfd47a05 part1 : remove UA agent checkings. r=heycam https://hg.mozilla.org/integration/autoland/rev/45a5af08e7f6 part2 : make CueStyleBox class-based. r=heycam https://hg.mozilla.org/integration/autoland/rev/f21dc82d9ba7 part3 : apply WebVTT cue settings. r=heycam https://hg.mozilla.org/integration/autoland/rev/b6a5f3dc8878 part4 : change font size internally in CueStyleBox. r=heycam https://hg.mozilla.org/integration/autoland/rev/eff6eff2d385 part5 : apply default style on cue when we don't use pseudo element. r=heycam
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: