We should enable these testcases for ::cue /testing/web-platform/meta/webvtt/rendering/cues-with-video/processing-model/selectors/*

hg error in cmd: hg push -r . -f try: pushing to ssh://hg.mozilla.org/try searching for changes remote: waiting for lock on working directory of /repo/hg/mozilla/try held by process '29892' on host 'hgssh4.dmz.scl3.mozilla.com' remote: abort: working directory of /repo/hg/mozilla/try: timed out waiting for lock held by hgssh4.dmz.scl3.mozilla.com:29892 abort: stream ended unexpectedly (got 0 bytes, expected 4)

Comment on attachment 8856349 [details] Bug 1353689 - selectors/cue : Enable testcases under */selector/* . Fix the padding and overflow issue. https://reviewboard.mozilla.org/r/128266/#review131076 ::: dom/media/webvtt/vtt.jsm:537 (Diff revision 1) > // Calculate the distance from the reference edge of the viewport to the text > // position of the cue box. The reference edge will be resolved later when > // the box orientation styles are applied. > + function convertCuePostionToPercentage(cuePosition) { > + if (cuePosition === "auto") { > + return 50; I'm surprised this works. Don't you need to check the line alignment here per https://w3c.github.io/webvtt/#webvtt-cue-position steps 2 and 3?

Comment on attachment 8856350 [details] Bug 1353689 - selectors/cue_function/italic_object: update testcase status. https://reviewboard.mozilla.org/r/128268/#review131078 Is there a plan to address these failures?

Comment on attachment 8856351 [details] Bug 1353689 - selectors/cue_function/bold_object: update testcase status. https://reviewboard.mozilla.org/r/128270/#review131080

Comment on attachment 8856352 [details] Bug 1353689 - selectors/cue_function/class_object: update testcase status. https://reviewboard.mozilla.org/r/128272/#review131082

Comment on attachment 8856353 [details] Bug 1353689 - selectors/cue_function/underline_object: update testcase status. https://reviewboard.mozilla.org/r/128274/#review131084

Comment on attachment 8856354 [details] Bug 1353689 - selectors/cue_function/voice_object: update testcase status. https://reviewboard.mozilla.org/r/128276/#review131086 ::: commit-message-d9855:1 (Diff revision 1) > +Bug 1353689 - cue_fucntion/voice_object: update testcase status. r=rillian Please correct directory name `cue_function` instead of `cue_fucntion`.

Comment on attachment 8856355 [details] Bug 1353689 - selectors/default_styles: update testcase status. https://reviewboard.mozilla.org/r/128278/#review131088

Comment on attachment 8856356 [details] Bug 1353689 - selectors/cue_function: update testcase status. https://reviewboard.mozilla.org/r/128280/#review131090

Comment on attachment 8856350 [details] Bug 1353689 - selectors/cue_function/italic_object: update testcase status. https://reviewboard.mozilla.org/r/128268/#review131078 After I go through the whole testcases, as far I can see, there are tree types of failure. 1. They almost depend on ::cue(selector), bug 1321489. Such as ::cue(i), ::cue(:past), ::cue(i:past)... 2. The css attribute "text-wrap: balance" we don't implement. 3. "background-image" to load a image. The first one is the most important and the hardest one, need to modify nsCSSRuleProcessor.cpp ...etc, And :haycam says we do not support any selector for pseudo-element now.

Comment on attachment 8856349 [details] Bug 1353689 - selectors/cue : Enable testcases under */selector/* . Fix the padding and overflow issue. https://reviewboard.mozilla.org/r/128266/#review131282 ::: dom/media/webvtt/vtt.jsm:537 (Diff revision 1) > // Calculate the distance from the reference edge of the viewport to the text > // position of the cue box. The reference edge will be resolved later when > // the box orientation styles are applied. > + function convertCuePostionToPercentage(cuePosition) { > + if (cuePosition === "auto") { > + return 50; It is different between the boxPosition and cuePosition. Now I'm fixing the boxPostion, boxPosition is the postion percentage relative to the video left edge. cuePosition is the cueText position percentage relative to the box's left edge. Step 2 and 3 are for the cueText position relative to box, not for boxPostion.

Comment on attachment 8856349 [details] Bug 1353689 - selectors/cue : Enable testcases under */selector/* . Fix the padding and overflow issue. https://reviewboard.mozilla.org/r/128266/#review131282 > It is different between the boxPosition and cuePosition. > Now I'm fixing the boxPostion, boxPosition is the postion percentage relative to the video left edge. > cuePosition is the cueText position percentage relative to the box's left edge. > > Step 2 and 3 are for the cueText position relative to box, not for boxPostion. Ok, thanks for clarifying.

On tryserver, there are still a lot of testcases FAIL that I expect them PASS. The result shows our cueText box position is a little higher than reference sample. It's weird because the position issue should be fixed in my first patch removing "style.margin", and also the failed testcases PASS on my local machine...

Comment on attachment 8859084 [details] Bug 1353689 - update /processing-model/* status. Disable tests whose result are not consistent. https://reviewboard.mozilla.org/r/131108/#review134160

Pushed by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e81924e4cff3 selectors/cue : Enable testcases under */selector/* . Fix the padding and overflow issue. r=rillian https://hg.mozilla.org/integration/autoland/rev/ebf24732e9b3 selectors/cue_function/italic_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/5179ebf1e982 selectors/cue_function/bold_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/d3ced5751998 selectors/cue_function/class_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/8d8d2824a763 selectors/cue_function/underline_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/7f2790b4c963 selectors/cue_function/voice_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/44c5f4b4cdfc selectors/default_styles: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/9a5b36fefb22 selectors/cue_function: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/80ac3ea1427e update /processing-model/* status. Disable tests whose result are not consistent. r=alwu

sorry had to back this out for web platform reftest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=93204785&repo=autoland&lineNumber=9919

Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b43acb94854 Backed out 9 changesets for web platform reftest failures

Comment on attachment 8860279 [details] Bug 1353689 - Disable tests about "background-image", because we have problem about loading a gif as background. https://reviewboard.mozilla.org/r/132302/#review135192

Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b77efb1bfd41 selectors/cue : Enable testcases under */selector/* . Fix the padding and overflow issue. r=rillian https://hg.mozilla.org/integration/autoland/rev/079e84d187bd selectors/cue_function/italic_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/b09585456f98 selectors/cue_function/bold_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/16b453f54028 selectors/cue_function/class_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/0e8f85520c3b selectors/cue_function/underline_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/b2237cc6ec73 selectors/cue_function/voice_object: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/cf61b0169824 selectors/default_styles: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/37f77f063aba selectors/cue_function: update testcase status. r=rillian https://hg.mozilla.org/integration/autoland/rev/6d0a1d6b3914 update /processing-model/* status. Disable tests whose result are not consistent. r=alwu https://hg.mozilla.org/integration/autoland/rev/c90ea6b2e05a Disable tests about "background-image", because we have problem about loading a gif as background. r=alwu

https://hg.mozilla.org/mozilla-central/rev/b77efb1bfd41 https://hg.mozilla.org/mozilla-central/rev/079e84d187bd https://hg.mozilla.org/mozilla-central/rev/b09585456f98 https://hg.mozilla.org/mozilla-central/rev/16b453f54028 https://hg.mozilla.org/mozilla-central/rev/0e8f85520c3b https://hg.mozilla.org/mozilla-central/rev/b2237cc6ec73 https://hg.mozilla.org/mozilla-central/rev/cf61b0169824 https://hg.mozilla.org/mozilla-central/rev/37f77f063aba https://hg.mozilla.org/mozilla-central/rev/6d0a1d6b3914 https://hg.mozilla.org/mozilla-central/rev/c90ea6b2e05a