Open Bug 1279654 Opened 8 years ago Updated 2 years ago

Create a PrintTargetRecording subclass of PrintTarget

Categories

(Core :: Graphics, task, P3)

Product:
Core
Component:
Graphics
Type:
task

Tracking

()

Status:
REOPENED
Milestone:
mozilla50
Tracking Flags:
Tracking Status
firefox50 --- fixed

People

(Reporter: jwatt, Assigned: jwatt)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

patch
(deleted), patch
mstange
: review+
Details | Diff | Splinter Review
We need a PrintTargetRecording subclass of PrintTarget.
Attached patch patch (deleted) — — Splinter Review
In addition to the obvious, I had previously been planing to make PrintTarget::MakeDrawTarget non-virtual, but PrintTargetRecording overrides that method and will likely continue to do so.
Attachment #8762247 - Flags: review?(mstange)
Attachment #8762247 - Flags: review?(mstange) → review+
Pushed by jwatt@jwatt.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/1bd6da31483d Create a PrintTargetRecording subclass of PrintTarget. r=mstange
https://hg.mozilla.org/mozilla-central/rev/1bd6da31483d
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox50: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
Depends on: 1280181
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Need to fix bug 1280324 before this can reland.
Depends on: 1280324
backed out also landed on m-c https://hg.mozilla.org/mozilla-central/rev/633b29c1f22c
Status: REOPENED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
sorry, my fault with the marking tool
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: feature
Blocks: 1302489
Priority: -- → P3
Whiteboard: [gfx-noted]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: