+++ This bug was initially created as a clone of Bug #1273549 +++

Review commit: https://reviewboard.mozilla.org/r/59782/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/59782/

(In reply to Rob Thijssen (:grenade - GMT) from comment #1) > Created attachment 8763580 [details] > Bug 1280476 - Split TC legacy test config (docker/windows); ; > > Review commit: https://reviewboard.mozilla.org/r/59782/diff/#index_header > See other reviews: https://reviewboard.mozilla.org/r/59782/ Oh boy, this one is going to keep me busy! :D I'll take a look tomorrow - I'm afraid my day is coming to an end now. Thanks Rob!

Comment on attachment 8763580 [details] Bug 1280476 - Split TC legacy test config (docker/windows); https://reviewboard.mozilla.org/r/59782/#review56848 Great job! nit: can you use `hg mv --after` to track the renames to preserve the history of the files that were renamed (as hg doesn't track this automatically)? If you've done that already (and mozreview just doesn't show it to me) then no worries. ::: taskcluster/ci/legacy/tasks/tests/fx_windows_test_base.yml:29 (Diff revision 1) > + - > + type: 'directory' > + path: 'public\test' > + expires: '{{#from_now}}1 year{{/from_now}}' > + #features: > + #allowPtrace: true You can remove these commented out lines, there is not support for features in generic worker.

Sorry, wrong bug! ^^^

Comment on attachment 8763580 [details] Bug 1280476 - Split TC legacy test config (docker/windows); Review request updated; see interdiff: https://reviewboard.mozilla.org/r/59782/diff/1-2/

Comment on attachment 8763580 [details] Bug 1280476 - Split TC legacy test config (docker/windows); https://reviewboard.mozilla.org/r/59782/#review56918 suggestions implemented

reviewed patch update from reviewboard

Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/830b31c9a64b Split TC legacy test config (docker/windows). r=pmoore

Backout by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/40969d155419 Backed out changeset 830b31c9a64b for causing decision task failures

Looks like a conflict between this patch and https://hg.mozilla.org/mozilla-central/rev/f8bee801a2a5 which landed on central in the same merge.

That should do it.

Comment on attachment 8764226 [details] [diff] [review] bug1280476_gecko_v1.patch Review of attachment 8764226 [details] [diff] [review]: ----------------------------------------------------------------- Thanks!

Pushed by cbook@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/dfd38b2b6778 Split TC legacy test config (docker/windows); r=pmoore https://hg.mozilla.org/mozilla-central/rev/c9edfe35619f resolved merge conflict with bug 1280437; r=grenade, a=tomcat