It is nice to recycle video buffer of FFmpegVideoDecoder.

ImageContainer::CreatePlanarYCbCrImage() creates SharedPlanarYCbCrImage. Then it is nice if video buffers are recycled is handled under SharedPlanarYCbCrImage.

Comment on attachment 8763823 [details] [diff] [review] patch part 1 - Update SendRecycleTexture usage :nical, can you feedback to the patches?

Comment on attachment 8764494 [details] [diff] [review] patch part 3 - Recycle TextureClient in SharedPlanarYCbCrImage Review of attachment 8764494 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/BufferTexture.cpp @@ +226,5 @@ > return ImageDataSerializer::SizeFromBufferDescriptor(mDescriptor); > } > > +gfx::IntSize > +BufferTextureData::GetCbCrSize() const Nit: this could return a Maybe<gfx::IntSize> (not very important). ::: gfx/layers/client/TextureClientRecycleAllocator.cpp @@ +88,5 @@ > +YCbCrTextureClientAllocationHelper::IsCompatible(TextureClient* aTextureClient) > +{ > + MOZ_ASSERT(aTextureClient->GetFormat() == gfx::SurfaceFormat::YUV); > + > + BufferTextureData* bufferData = aTextureClient->GetInternalData()->AsBufferTextureData(); Ideally we shouldn't be poking at the internal data, but I guess we don't have a good API to do what you want to do here so it will be ok for now.

Comment on attachment 8764476 [details] [diff] [review] patch part 2 - Handle race condition in CompositableClient::GetTextureClientRecycler() Review of attachment 8764476 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/client/CompositableClient.cpp @@ +276,5 @@ > + ImageBridgeChild::GetSingleton()->GetMessageLoop()->PostTask(runnable.forget()); > + > + // should stop the thread until done. > + while (!done) { > + barrier.Wait(); Hopefully we don't run into this case too often...

> > ::: gfx/layers/client/TextureClientRecycleAllocator.cpp > @@ +88,5 @@ > > +YCbCrTextureClientAllocationHelper::IsCompatible(TextureClient* aTextureClient) > > +{ > > + MOZ_ASSERT(aTextureClient->GetFormat() == gfx::SurfaceFormat::YUV); > > + > > + BufferTextureData* bufferData = aTextureClient->GetInternalData()->AsBufferTextureData(); > > Ideally we shouldn't be poking at the internal data, but I guess we don't > have a good API to do what you want to do here so it will be ok for now. Yea, we do not have a good API for now, then I used a bit dirty way.

Apply the comment.

Rebased.

Rebased.

Pushed by sikeda@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/00203ba4e8bf Recycle SharedPlanarYCbCrImage r=nical