David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Description • 8 years ago

... and friends. We don't want to initialize gfxPlatform in the GPU process since it carries a ton of baggage with it. The first step at least is separating out D3D11 device logic.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 1 • 8 years ago

This introduces a new DeviceManagerD3D11 class to hold all the various D3D11 objects we create. Currently it just wraps gfxWindowsPlatform. Additionally, the platform accessors are now hidden, and all callers have been fixed up to go through DeviceManagerD3D11.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 2 • 8 years ago

Move the ten bazillion lines of D3D11 device validation logic out of gfxWindowsPlatform into a new D3D11Checks.cpp. I put GetDxgiDesc in there too since it's only ever used for validation.

(note: the moz.build changes are not right, but unified builds broke horribly when I added a second file so I'll go back and fix that at the end of this queue.)

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 3 • 8 years ago

This is not enough to make the D3D11 compositor usable on the GPU process yet. But it's the most annoying step to review.

This is all code motion.

	David Anderson [:dvander] - inactive, e-mail if emergency Assignee
	Comment 4 • 8 years ago

Correct patch - sorry about that.

	Pulsebot
	Comment 5 • 8 years ago

Pushed by danderson@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d1cd9be20f92
Add DeviceManagerD3D11 as a wrapper around gfxWindowsPlatform. (bug 1282364 part 1, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/007d791665b8
Move D3D11 checking logic out of gfxWindowsPlatform. (bug 1282364 part 2, r=mattwoodrow)
https://hg.mozilla.org/integration/mozilla-inbound/rev/8508083db4ac
Move D3D11 device creation out of gfxWindowsPlatform. (bug 1282364 part 3, r=mattwoodrow)

	Carsten Book [:Tomcat]
	Comment 6 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/d1cd9be20f92
https://hg.mozilla.org/mozilla-central/rev/007d791665b8
https://hg.mozilla.org/mozilla-central/rev/8508083db4ac