Fix InterpolateRow_Any_AVX2 does not work correctly. It is recognized during looking into Bug 1275441. https://dxr.mozilla.org/mozilla-central/source/media/libyuv/source/row_any.cc#518 The problem is already addressed in master libyuv. https://chromium.googlesource.com/external/libyuv/+/af6f25245e6ca2245e8781bfecc7f215d319da03%5E%21/source/row_any.cc

It seems better just update InterpolateRow_Any_AVX2.

(In reply to Sotaro Ikeda [:sotaro] from comment #0) > > The problem is already addressed in master libyuv. > https://chromium.googlesource.com/external/libyuv/+/ > af6f25245e6ca2245e8781bfecc7f215d319da03%5E%21/source/row_any.cc The following is related bug. https://webrtc-codereview.appspot.com/30759004

https://webrtc-codereview.appspot.com/30759004 enables InterpolateRow_Any_AVX2 with the following. > +#define HAS_INTERPOLATEROW_AVX2 InterpolateRow_Any_AVX2 is enabled when LIBYUV_VERSION is 1135, but gecko's LIBYUV_VERSION is 971. InterpolateRow_Any_AVX2 seems to be enabled accidentally during porting to gecko. https://dxr.mozilla.org/mozilla-central/source/media/libyuv/include/libyuv/version.h#14

https://webrtc-codereview.appspot.com/30759004 has the following changes. [1] Enable HAS_INTERPOLATEROW_AVX2 [2] Fix InterpolateRow_Any_AVX2 [3] Update InterpolateRow_AVX2() [1] is already done in gecko. For [2] It seems better to use attachment 8765796 [details] [diff] [review] since original patch could not apply cleanly. [3] does not fix the bug, but it is for improvimg performance. It seems better to take the patch.

attachment 8766730 [details] [diff] [review] is just rebased version of [3] in https://webrtc-codereview.appspot.com/30759004.

Should we just update libyuv wholesale?

Thanks for the advice. I am going to check about it.

(In reply to Jeff Muizelaar [:jrmuizel] from comment #8) > Should we just update libyuv wholesale? I created Bug 1284803 to update libyuv.