Closed
Bug 1285007
Opened 8 years ago
Closed 8 years ago
Make one-click loaner more discoverable
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
The most common use case for a one click loaner is likely to debug a failing job. However, when a user clicks on one of these jobs in treeherder, they get the failure tab, which just shows a list of failure lines and bug suggestions.
I think we ought to detect if reproducing a job on a one-click loaner is possible for these jobs, and pop up a prominent and informative button that lets the user go straight to the one-click loaner page from the failure tab. [ possibly not too prominent, as sheriffs still need the information in the failure summary for other reasons ]
We shouldn't do this before the basics of one click loaners are in place, as we don't want to heavily advertise a feature that won't work well "out of the box".
Updated•8 years ago
|
Priority: -- → P2
Comment 1•8 years ago
|
||
I think I may have already suggested this and someone said it was a bad idea, but now I can't remember.. so I'm going to suggest it again :). But what if one-click-loaner was added to the 'retrigger dropdown', along side retrigger and backfill? After all a one-click-loaner is essentially just retriggering the task with TASKCLUSTER_INTERACTIVE set.
I think the argument against doing this was that the retrigger button shouldn't be a dropdown in the first place. I agree with that, but as long as it is, it seems like a decent place to put it. If there is already a timeline to remove that dropdown however, then yeah, this suggestion makes no sense.
Comment 2•8 years ago
|
||
+1 to the idea
Assignee | ||
Comment 3•8 years ago
|
||
I'm going to implement something like :ahal's idea here
Assignee: nobody → wlachance
Summary: Expose one-click loaner link from failure tab → Make one-click loaner more discoverable
Comment 4•8 years ago
|
||
Assignee | ||
Comment 5•8 years ago
|
||
Comment on attachment 8822731 [details]
[treeherder] wlach:1285007 > mozilla:master
There's a screenshot of the way the functionality works in the pull request.
I'm pretty happy with how this came out, and it gives us space to expose more taskcluster-specific options (e.g. bug 1322433) in the future.
Attachment #8822731 -
Flags: review?(tojonmz)
Attachment #8822731 -
Flags: feedback?(ahalberstadt)
Comment 6•8 years ago
|
||
Comment on attachment 8822731 [details]
[treeherder] wlach:1285007 > mozilla:master
r+ with my comments added to the PR on possible consistency improvements. I assume we are ok with the following also:
o Backfill requires two clicks to invoke, w/recent changes it needed only one
o Inspect Task and One Click Loaner are now in two places
Attachment #8822731 -
Flags: review?(tojonmz) → review+
Updated•8 years ago
|
Status: NEW → ASSIGNED
Comment 7•8 years ago
|
||
Comment on attachment 8822731 [details]
[treeherder] wlach:1285007 > mozilla:master
Thanks, looks good!
Attachment #8822731 -
Flags: feedback?(ahalberstadt) → feedback+
Comment 8•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/8614ecfec4deb8842659cce44f85c5bcbdfed55d
Bug 1285007 - Make Taskcluster options more discoverable (#2052)
Create an per-job "extras" job button in Treeherder and put "backfill"
and the current set of taskcluster options (one click loaner, inspect task)
in there, if they exist.
Assignee | ||
Comment 9•8 years ago
|
||
Let's call this fixed.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•