Closed
Bug 1285177
Opened 8 years ago
Closed 7 years ago
Always show the cancel all jobs button
Categories
(Tree Management :: Treeherder, defect, P2)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1194467
People
(Reporter: emorley, Unassigned)
Details
Currently it's only shown if the user has sheriff permissions (the "is_staff" Django group) or if the repo is in a Try group.
The reason for this limitation is that for trees that have coalescing (eg non-try), if a buildbot pending job is cancelled, it can cancel others on the repo and not just that job.
However we've now had another case of a try-like repo (nss-try; previously the gaia repo) not have the cancel-all button shown when it should be, causing user confusion (the button is not shown at all, rather than being disabled, which is pretty confusing to the user).
Let's just remove the check entirely. Buildbot is going away, and I'm not sure how much of a problem this really was in practice (it was only ever enforced in the UI and not via the API or buildapi).
Comment 1•8 years ago
|
||
Quite a big problem, we did it because developers actually were cancelling all on their broken pushes to m-i and thus cancelling the tests on and above their backouts.
Comment 2•8 years ago
|
||
A simpler solution might be to make displaying this button conditional on a repo being in the try repository group.
Comment 3•8 years ago
|
||
(In reply to William Lachance (:wlach) from comment #2)
> A simpler solution might be to make displaying this button conditional on a
> repo being in the try repository group.
s/A simpler/Another/ :)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Phil Ringnalda (:philor) from comment #1)
> Quite a big problem, we did it because developers actually were cancelling
> all on their broken pushes to m-i and thus cancelling the tests on and above
> their backouts.
Yeah I realise they were 2-3 years ago, but do you think they still would now, when many just ignore the pushes and leave it up to sheriffs?
(In reply to William Lachance (:wlach) from comment #2)
> A simpler solution might be to make displaying this button conditional on a
> repo being in the try repository group.
That's the current behaviour. The think the root cause is really that the schema is:
group:
id
name
description
Whereas we need it to be:
group:
id
name
description
is_try_group
...since we have multiple groups that want try-like behaviour (in terms of the cancel-all button), but the group named "try" really is "gecko try". So we have the choice of lumping unrelated repos in that group (when they aren't directly related to gecko) or hardcoding several group names.
Though that said, maybe the root cause is really: "we need to be able to put assign repos with multiple categories and slive them in various ways in menus/behaviours, and not just a single group" (eg can filter by all gecko repos, or all "try-like" repos etc)
Anyway, this has gone way past the effort it's worth I think. I'm inclined now to just put nss-try in the try group alongside gecko try, comm-central try and gaia.
Reporter | ||
Updated•8 years ago
|
Assignee: emorley → nobody
Reporter | ||
Updated•7 years ago
|
Component: Treeherder → Treeherder: Job Triggering & Cancellation
Reporter | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Assignee | ||
Updated•3 years ago
|
Component: Treeherder: Job Triggering & Cancellation → TreeHerder
You need to log in
before you can comment on or make changes to this bug.
Description
•