Closed Bug 1288475 Opened 8 years ago Closed 8 years ago

Split webconsole utils file into client and server parts

Categories

(DevTools :: Console, enhancement, P1)

Product:
DevTools
Component:
Console
Version:
46 Branch
Type:
enhancement

Tracking

(firefox51 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 51
Iteration:
51.1 - Aug 15
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

(Whiteboard: [devtools-html])

Attachments

(2 files)

Bug 1288475 - Split webconsole utils.js into separate client and server parts
(deleted), text/x-review-board-request
tromey
: review+
MattN
: review+
Details
Bug 1288475 - Remove code unused in client and server versions of webconsole utils;
(deleted), text/x-review-board-request
tromey
: review+
Details
The webconsole utils file is in shared/ but mostly it's used by the server. Let's split it into two files and put it in their respective places. Here's the stuff being used by client: https://dxr.mozilla.org/mozilla-central/search?q=path:devtools/client+%22WebConsoleUtils.%22
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Whiteboard: [devtools-html]
Assignee: bgrinstead → nobody
Status: ASSIGNED → NEW
Flags: qe-verify?
Priority: -- → P2
Comment on attachment 8777966 [details] Bug 1288475 - Split webconsole utils.js into separate client and server parts Matt, can you have a look at the change in toolkit/components/passwordmgr/InsecurePasswordUtils.jsm? I got rid of a dependency on a small wrapper for Services.strings from the webconsole: https://dxr.mozilla.org/mozilla-central/source/devtools/shared/webconsole/utils.js#542.
Attachment #8777966 - Flags: review?(MattN+bmo)
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 51.1 - Aug 15
Priority: P2 → P1
Comment on attachment 8777966 [details] Bug 1288475 - Split webconsole utils.js into separate client and server parts https://reviewboard.mozilla.org/r/69326/#review66542 r=me on InsecurePasswordUtils.jsm
Attachment #8777966 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8777966 [details] Bug 1288475 - Split webconsole utils.js into separate client and server parts https://reviewboard.mozilla.org/r/69326/#review66708 Thank you. This looks good.
Attachment #8777966 - Flags: review?(ttromey) → review+
Attachment #8777967 - Flags: review?(ttromey) → review+
Comment on attachment 8777967 [details] Bug 1288475 - Remove code unused in client and server versions of webconsole utils; https://reviewboard.mozilla.org/r/69328/#review66710 Thank you. This looks great, I love deletions.
Comment on attachment 8777966 [details] Bug 1288475 - Split webconsole utils.js into separate client and server parts Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69326/diff/1-2/
Attachment #8777966 - Attachment description: Bug 1288475 - Split webconsole utils.js into separate client and server parts; → Bug 1288475 - Split webconsole utils.js into separate client and server parts
Comment on attachment 8777967 [details] Bug 1288475 - Remove code unused in client and server versions of webconsole utils; Review request updated; see interdiff: https://reviewboard.mozilla.org/r/69328/diff/1-2/
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8795e6dad405 Split webconsole utils.js into separate client and server parts;r=MattN,tromey https://hg.mozilla.org/integration/autoland/rev/4da5f346fddf Remove code unused in client and server versions of webconsole utils;r=tromey
https://hg.mozilla.org/mozilla-central/rev/8795e6dad405 https://hg.mozilla.org/mozilla-central/rev/4da5f346fddf
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
Flags: qe-verify? → qe-verify-
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: