Closed
Bug 1289463
Opened 8 years ago
Closed 6 years ago
Split webconsole network-monitor.js file into client and server parts
Categories
(DevTools :: Console, enhancement, P3)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bgrins, Unassigned)
References
Details
(Whiteboard: [reserve-html])
The webconsole network-monitor.js file is in shared/ but mostly it's used on both the client and server. Let's split it into two files and put them in their respective places.
Reporter | ||
Updated•8 years ago
|
Blocks: devtools-html-phase2
Updated•8 years ago
|
Whiteboard: [devtools-html]
Updated•8 years ago
|
Flags: qe-verify?
Priority: -- → P2
Updated•8 years ago
|
Flags: qe-verify? → qe-verify-
Comment 1•8 years ago
|
||
I see this file being used on the server only, in devtools\server\actors\webconsole.js:
loader.lazyRequireGetter(this, "NetworkMonitor", "devtools/shared/webconsole/network-monitor", true);
loader.lazyRequireGetter(this, "NetworkMonitorChild", "devtools/shared/webconsole/network-monitor", true);
loader.lazyRequireGetter(this, "ConsoleProgressListener", "devtools/shared/webconsole/network-monitor", true);
loader.lazyRequireGetter(this, "StackTraceCollector", "devtools/shared/webconsole/network-monitor", true);
But I couldn't find any usages in devtools\client\.
Am I missing something?
Updated•8 years ago
|
Priority: P2 → P3
Whiteboard: [devtools-html] → [reserve-html]
Comment 2•8 years ago
|
||
(In reply to Patrick Brosset <:pbro> from comment #1)
> But I couldn't find any usages in devtools\client\.
> Am I missing something?
That sounds correct to me as well.
Maybe this bug can be repurposed to move network-monitor (and throttler and
maybe other things) to devtools/server.
Updated•6 years ago
|
Product: Firefox → DevTools
Comment 3•6 years ago
|
||
The file is not used anymore on the client, and (I think) was moved to the server https://searchfox.org/mozilla-central/rev/6c82481caa506a240a626bb44a2b8cbe0eedb3a0/devtools/server/actors/network-monitor.js
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•