Closed Bug 1289412 Opened 8 years ago Closed 8 years ago

Two loading throbbers shown for YouTube videos

Categories

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

48 Branch
ARM
Android
defect

Tracking

(firefox49 wontfix, firefox50 wontfix, firefox51 wontfix, firefox52 wontfix, firefox53 wontfix, firefox54 verified, firefox55 verified)

VERIFIED FIXED
Firefox 55
Tracking Status
firefox49 --- wontfix
firefox50 --- wontfix
firefox51 --- wontfix
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- verified
firefox55 --- verified

People

(Reporter: marco, Assigned: timdream)

References

Details

(Keywords: verifyme, Whiteboard: [webcompat][needsdiagnosis])

Attachments

(2 files)

Attached image Screenshot_20160726-150615.png (deleted) —
No description provided.
I was also able to reproduce this issue. Tested on: - LG G4 (Android 5.1) - Nexus 9 (Android 6.0.1) - Nexus 5 (Android 6.0) Steps to reproduce: 1. Go to youtube.com 2. Load any video 3. Navigate trough the video using the seek control bar. Expected results: The video loads correctly and only one throbber is displayed. Actual results: When navigating using the seek control bar two throbbers are being displayed.
OS: Unspecified → Android
QA Contact: bogdan.surd
Hardware: Unspecified → ARM
Priority: -- → P3
Whiteboard: [webcompat][needsdiagnosis]
Mass wontfix for bugs affecting firefox 52.
This is a very visible bug that partners are starting to report. Does anyone have any ideas? Has it always been this way?
snorp, is there someone who looks at fennec-specific media stuff? (this doesn't repro on desktop if i send a mobile UA)
Flags: needinfo?(snorp)
I've seen the two throbbers for a long time. I'd guess one is content, and the other is our own? Anthony, do you know what could be happening? Blake, if your team has some time for this that would be helpful.
Flags: needinfo?(snorp)
Flags: needinfo?(bwu)
Flags: needinfo?(ajones)
AFAIK, the second spinner comes from our videocontrol. Tim and Ray, May we have your help to check it?
Flags: needinfo?(timdream)
Flags: needinfo?(ralin)
Flags: needinfo?(bwu)
Flags: needinfo?(ajones)
(In reply to James Willcox (:snorp) (jwillcox@mozilla.com) from comment #7) > I've seen the two throbbers for a long time. I'd guess one is content, and the other is our own? Yes, I think that's what causes this case. (In reply to Blake Wu [:bwu][:blakewu] from comment #8) > AFAIK, the second spinner comes from our videocontrol. If the first spinner comes out from content itself, then I don't think we could have a straight fix to this as we could not detect what's over <video> in video controls.
Flags: needinfo?(ralin) → needinfo?(alam)
Hi Anthony, Do you have any idea to mitigate this issue? I don't think we could hide our spinner for just YouTube, but look bad on other websites. Thanks.
Do we know what Chrome does?
(In reply to Mike Kaply [:mkaply] from comment #11) > Do we know what Chrome does? I didn't look into the implementation details of Chrome, but it appears that Chrome doesn't show something like spinner while loading. So, in this case, one spinner look sensible on Chrome.
So maybe we shouldn't be showing a spinner ourselves? And relying on content?
That would be something :alam needs to answer. Thanks Ray.
Flags: needinfo?(timdream)
Yeah, this is a bit weird. Our spinner seems unnecessary. It seems like most videos on the web have a UI to handle this type of "things are loading" feedback themselves. Does anyone know why we still show our own spinner? Snorp is there a history lesson here?
Flags: needinfo?(alam) → needinfo?(snorp)
Yeah I don't know what the story is here. My guess is that we wanted something for when you're playing a raw video directly (not embedded in a page)? In any case, killing the spinner seems ok to me.
Flags: needinfo?(snorp)
Assignee: nobody → timdream
Status: NEW → ASSIGNED
Comment on attachment 8860803 [details] Bug 1289412 - Remove throbber/spinner from mobile video element. https://reviewboard.mozilla.org/r/132774/#review135700
Attachment #8860803 - Flags: review?(s.kaspari) → review+
It looks like a very simple change, should we uplift?
(In reply to Marco Castelluccio [:marco] from comment #20) > It looks like a very simple change, should we uplift? Yes, please. Partners have reported this.
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9b5e7f9f2816 Remove throbber/spinner from mobile video element. r=sebastian
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Let's get it verified before request for uplift.
Flags: needinfo?(timdream)
Keywords: verifyme
Devices: - Nexus 6 (Android 7.0); - Honor 8 (Android 6.0). Build: 55.0a1 (05-01-2017).
Comment on attachment 8860803 [details] Bug 1289412 - Remove throbber/spinner from mobile video element. Approval Request Comment [Feature/Bug causing the regression]: Feature [User impact if declined]: As described in STR [Is this code covered by automated tests?]: [Has the fix been verified in Nightly?]: Yes [Needs manual test from QE? If yes, steps to reproduce]: No [List of other uplifts needed for the feature/fix]: Just this bug. [Is the change risky?]: No. [Why is the change risky/not risky?]: Remove an UI, instead of adding an feature. [String changes made/needed]: No.
Flags: needinfo?(timdream)
Attachment #8860803 - Flags: approval-mozilla-beta?
Comment on attachment 8860803 [details] Bug 1289412 - Remove throbber/spinner from mobile video element. Fix two loading throbbers shown issue and was verified. Beta54+. Should be in 54 beta 6 for mobile.
Attachment #8860803 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified as fixed on Beta 54.0b6. Devices: -HTC 10 (Android 6.0.1) -Huawei Honor 5X (Android 5.1.1) -Prestigio Grace X5 (Android 4.4.2)
Status: RESOLVED → VERIFIED
Blocks: 1450013
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: