+++ This bug was initially created as a clone of Bug #1289412 +++ Happens again since bug 1444489.

Might be fixed by bug 1449532. Will investigate. Thanks for filing.

I would need to port bug 1289412 to the desktop control.

Comment on attachment 8964236 [details] Bug 1450013 - Remove throbber/spinner from mobile video controls. https://reviewboard.mozilla.org/r/232978/#review238466 Had a quick look, and I have questions, so asking those so hopefully I can r+ tomorrow with these answered / resolved. ::: toolkit/themes/shared/media/videocontrols.css:410 (Diff revision 1) > > -.statusIcon[type="throbber"] { > +.controlsContainer:not(.touch) .statusIcon[type="throbber"] { > background: url(chrome://global/skin/media/throbber.png) no-repeat center; > } > > -.statusIcon[type="throbber"][stalled] { > +.controlsContainer:not(.touch) .statusIcon[type="throbber"][stalled] { Why do we not need to do this on the non-touch controls? Also, I'm not sure that identifying 'touch' and 'mobile' is right here... did a bug get filed to use touch controls on desktop for tablets without mice? If so, might be worth making a note there that if/when we implement that, we'd have to change these rules to actually be android-specific. Or something. ::: toolkit/themes/shared/media/videocontrols.css:414 (Diff revision 1) > > -.statusIcon[type="throbber"][stalled] { > +.controlsContainer:not(.touch) .statusIcon[type="throbber"][stalled] { > background: url(chrome://global/skin/media/stalled.png) no-repeat center; > } > > -.statusIcon[type="error"] { > +.controlsContainer .statusIcon[type="error"] { Why is this necessary? `type` can't be both throbber and error, so I don't think we need to increase the specificity of this rule?

Comment on attachment 8964236 [details] Bug 1450013 - Remove throbber/spinner from mobile video controls. https://reviewboard.mozilla.org/r/232978/#review238466 > Why do we not need to do this on the non-touch controls? > > Also, I'm not sure that identifying 'touch' and 'mobile' is right here... did a bug get filed to use touch controls on desktop for tablets without mice? If so, might be worth making a note there that if/when we implement that, we'd have to change these rules to actually be android-specific. Or something. We need to do this to workaround the conflict of our design and m.youtube.com. See bug 1289412. I'll add a note. > Why is this necessary? `type` can't be both throbber and error, so I don't think we need to increase the specificity of this rule? We don't need to. I simply did this to keep selectors aligned. I will remove this.

(In reply to Tim Guan-tin Chien [:timdream] (please needinfo) from comment #5) > Comment on attachment 8964236 [details] > Bug 1450013 - Remove throbber/spinner from mobile video element. > > https://reviewboard.mozilla.org/r/232978/#review238466 > > > Why do we not need to do this on the non-touch controls? > > We need to do this to workaround the conflict of our design and > m.youtube.com. See bug 1289412. Sorry, you answered the inverse of the question I was trying to ask. I understood from the other bug why we're doing this. What I don't understand is why the fix/workaround/change is limited to touch/mobile. Why don't we remove the throbber everywhere? Does Youtube's design on desktop differ significantly (I am not sure!), and if so, is that the only reason?

(In reply to :Gijs (back Tuesday April 3rd) from comment #6) > Sorry, you answered the inverse of the question I was trying to ask. > > I understood from the other bug why we're doing this. > > What I don't understand is why the fix/workaround/change is limited to > touch/mobile. Why don't we remove the throbber everywhere? Does Youtube's > design on desktop differ significantly (I am not sure!), and if so, is that > the only reason? The workaround is limited to mobile because it only happens on m.youtube.com. On desktop YouTube, they don't use the browser native controls at all (so we never show the extra throbber there). And yes, bug 1289412 is the only reason that I know of on why we need to remove the throbber on mobile.

Comment on attachment 8964236 [details] Bug 1450013 - Remove throbber/spinner from mobile video controls. https://reviewboard.mozilla.org/r/232978/#review238792 r=me, though it's a bit sad that we will now lack any throbber at all for non-youtube users. Then again, I'm kind of surprised anyway that major sites rely on builtin controls, this restores the status quo, and either way I can't see any obvious better options... :-(

Pushed by timdream@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8a83c7e6ad67 Remove throbber/spinner from mobile video controls. r=Gijs

Verified issue as fixed in Nightly 61.0a1 (2018-04-05) on Samsung Note 8 (Android 7.1.1) & Samsung Galaxy S7 (Android 7.0). Only 1 throbber is shown now when scrolling through the video. Filled in another issue as when the video is in Full screen mode there is no throbber shown now. https://bugzilla.mozilla.org/show_bug.cgi?id=1451730