Closed Bug 1291786 Opened 8 years ago Closed 8 years ago

stylo: Deal with mismatch between Gecko's eRestyle_Subtree and servo's RESTYLE_SELF + RESTYLE_DESCENDANTS

Categories

(Core :: CSS Parsing and Computation, defect, P1)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: emilio, Assigned: heycam)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1291786 - stylo: Move eRestyle_Subtree translation handling to Servo.
(deleted), text/x-review-board-request
bholley
: review+
Details
TL;DR: RESTYLE_SELF should not (always) run selector matching on descendants (that's eRestyle_Subtree, which currently is lacking on Servo). This is a known (hopefully soon-to-be-addressed issue). We treat both like the same right now. RESTYLE_DESCENDANTS and eRestyle_SomeDescendants share binary representations right now, but the meanings for Gecko and Servo are different (all vs. some). In practice this doesn't matter much since it's impossible for a Gecko-generated eRestyle_SomeDescendants to reach the Servo restyle manager, but we should be aware of this and presumably give it a more meaningful name, or pick another spot, or something.
Depends on: 1338461
Bug 1346018 covers the SomeDescendants case, and bug 1338461 covers eRestyle_StyleAttribute. I think we should deal with the remaining mismatch in RestyleHint::from<nsRestyleHint>. We can make the eRestyle_Subtree bit position correspond to RESTYLE_DESCENDANTS, and add in RESTYLE_SELF when we encounter it. This is a 5-minute job.
Assignee: nobody → cam
Priority: -- → P1
Summary: stylo: Align restyle hint meanings between Servo and Gecko. → stylo: Deal with mismatch between Gecko's eRestyle_Subtree and servo's RESTYLE_SELF + RESTYLE_DESCENDANTS
Comment on attachment 8845907 [details] Align eRestyle_Subtree value with RESTYLE_DESCENDANTS. https://reviewboard.mozilla.org/r/119032/#review121112
Attachment #8845907 - Flags: review?(bobbyholley) → review+
Comment on attachment 8845906 [details] Bug 1291786 - stylo: Move eRestyle_Subtree translation handling to Servo. https://reviewboard.mozilla.org/r/119030/#review121114
Attachment #8845906 - Flags: review?(bobbyholley) → review+
Attachment #8845907 - Attachment is obsolete: true
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d35259473a29 stylo: Move eRestyle_Subtree translation handling to Servo. r=bholley
https://hg.mozilla.org/mozilla-central/rev/d35259473a29
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: