Closed
Bug 1292188
Opened 8 years ago
Closed 8 years ago
Automatically retrieve l10n changesets from elmo
Categories
(Release Engineering :: Applications: Shipit, defect)
Release Engineering
Applications: Shipit
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rail, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
This page contains links to l10n changesets for different products:
https://l10n.mozilla.org/shipping/drivers
Ship-it should:
* Fetch the data from elmo automatically (frontend or backend)
* Hide the l10n textarea and make it editable in advanced mode (just in case we have issues with the data)
* Remove the l10n dashboard check: bug 1290485
* Build2 to reuse build1 l10n data by default with ability to force refresh
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → jlorenzo
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8779730 [details]
PR
> Ship-it should:
> * Fetch the data from elmo automatically (frontend or backend)
Done on the client side. I added tests for `getElmoUrl()`, but I haven't for `populateL10nChangesets()` which performs the async request and the UI manipulation. The easiest way to test it would be to use a mocking library (like sinon.js). At the first glance, I didn't want to increase the numbers of external libs, but if you're okay with me adding it, I'll be pleased to do so (probably in a follow up).
> * Hide the l10n textarea and make it editable in advanced mode (just in case we have issues with the data)
Done. The field remain disabled while the Ajax request is still pending.
> * Remove the l10n dashboard check: bug 1290485
Sylvestre has a patch there. I'll wait until this bug lands.
> * Build2 to reuse build1 l10n data by default with ability to force refresh
Discussed with :rail, it's better in a follow up. See bug 1294107.
Attachment #8779730 -
Flags: review?(sledru)
Attachment #8779730 -
Flags: review?(rail)
Reporter | ||
Updated•8 years ago
|
Attachment #8779730 -
Flags: review?(rail) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 4•8 years ago
|
||
Comment on attachment 8779730 [details]
PR
You are moving too fast for me!
Attachment #8779730 -
Flags: review?(sledru)
Updated•3 years ago
|
Component: Applications: ShipIt (backend) → Applications: ShipIt
You need to log in
before you can comment on or make changes to this bug.
Description
•