Closed
Bug 1292997
Opened 8 years ago
Closed 8 years ago
With Win10 High Contrast dark theme menubar is black text on black
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 1022547
People
(Reporter: riccardo.macri, Unassigned)
References
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
User Agent: Mozilla/5.0 (Windows NT 10.0; rv:48.0) Gecko/20100101 Firefox/48.0
Build ID: 20160726073904
Steps to reproduce:
On a fresh installation of Windows 10 (32 bit) I installed Firefox 48.0 with no settings import.
Actual results:
When I press ALT the menubar appears but the item title text (File, Edit, View...) is black. If you click on a menu the menu drops down and the items are properly coloured.
Expected results:
A light colour should be used for the menu bar text to make it readable.
Additionally, all white background/dark text should be avoided, eg: the certificate name to the left of the URL bar and also the bottom-left link popup (not shown in screenshot) is also white background/dark text when FF is in high contrast mode.
Why:People with broken eye retinas like me have real problems with large splodges of light or reading black text on a white background. Aesthetics and graphic design necessarily take a back seat for us.
Comment 1•8 years ago
|
||
about menu, the text color is defined to be black here.
https://dxr.mozilla.org/mozilla-central/rev/6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8/browser/themes/windows/browser-aero.css#374
> #main-menubar:not(:-moz-lwtheme):not(:-moz-window-inactive) {
> background-color: rgba(255,255,255,.5);
> color: black;
> }
background-color rule has no effect for '-moz-appearance: menuitem;' (not sure why tho...)
https://dxr.mozilla.org/mozilla-central/rev/6b65dd49d4f045c0a9753ce60bdb4b7b4aaedcf8/toolkit/themes/windows/global/menu.css#17
> menu,
> menuitem,
> menucaption,
> .splitmenu-menuitem {
> -moz-appearance: menuitem;
> -moz-box-align: center;
> color: MenuText;
> font: menu;
> list-style-image: none;
> -moz-image-region: auto;
> }
anyway, we should use system color instead of "black" or "background-color: rgba(255,255,255,.5);".
Comment 2•8 years ago
|
||
Dão, can we look at this as part of your work on high-contrast stuff on Windows?
Flags: needinfo?(dao+bmo)
Comment 3•8 years ago
|
||
In fact (I'm being slow going through bugmail post-PTO...), looks like the offending CSS no longer applies on win10 as part of bug 1008225? Not sure if the same problem applies in HCM on win7 - presumably not anymore, because post-bug-1008225 the CSS is in a glass container. Dão can you verify and close as dupe/wfm if I'm right?
Comment 4•8 years ago
|
||
Going to take care of this in bug 1022547.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(dao+bmo)
Resolution: --- → DUPLICATE
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•