Closed Bug 1295463 Opened 8 years ago Closed 8 years ago

Tweak visual styling for hover/mouseover state for results

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox51 --- affected

People

(Reporter: adw, Assigned: adw)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

Does that mean we implement the double selection (real/hover)?
I'm not sure I understand the question. Selection is blue, and the only time that both a result and a one-off should be blue is when you key down to a result and alt+up/down to a one-off.
Working on this as part of bug 1295458.
Assignee: nobody → adw
Status: NEW → ASSIGNED
Depends on: 1295458
Blocks: 1337003
Status update for this bug: this is entirely part of bug 1295458, so when that bug is fixed, this one will be too.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Attached image screenshot.png (deleted) —
The implementation of the hover/mouseover state is not exactly as in the mock-up from the Description. For instance, I see the following: - in the mock-up on mouse hover the one-off buttons have a clear and bold focus ring around each button (lines going from top to bottom) but with this implementation, the lines of the focus ring are interrupted. - the background of the one-off buttons seems darker in the mock-up but with this implementation, the background of the one-off buttons is lighter (this make the hover/mouseover state much more discrete especially on Mac OS X) Was this intentional? Also, please be aware that there are some hover/mouseover issues when high contrast themes are enabled on Windows. Logged Bug 1358136 to cover this.
Flags: needinfo?(adw)
Thanks Simona, you're right on both counts. It looks like Stephen's CSS is using an alpha value of 10% for the one-off hover, but I used 6% for some reason. I'll file a new bug for each of those.
Flags: needinfo?(adw)
Based on Comments 6 and 8, and considering Bug 1358677 and Bug 1358136 are tracked in Bug 1180944, marking this as Verified Fixed (verified on using Nightly 55 on Windows 10, Ubuntu 16.04 and Mac OS X 10.12)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: