Closed
Bug 1297311
Opened 8 years ago
Closed 8 years ago
Remove MediaDataDecoder::ConfigurationChanged API and ensure decoders are only ever created once extradata is known
Categories
(Core :: Audio/Video: Playback, defect, P3)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jya, Assigned: jya)
References
Details
Attachments
(2 files)
For the Windows and Gonk decoder, we feed AnnexB type data letting the decoder handle in-band SPS/PPS NAL.
For the other decoders, they are wrapped in a H264Converter wrapper that monitor the input stream for the SPS NAL; and only instantiate a new decoder once this extradata has been extracted.
The MediaFormatReader now always create a new decoder whenever the resolution change. We do not rely on the decoders being able to handle change of resolutions.
We can remove this. We would have to also wrap annexB decoder in the H264Converter.
|
||
Updated•8 years ago
|
Priority: -- → P3
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → jyavenard
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8794690 -
Flags: review?(cpearce)
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8794690 -
Flags: review?(cpearce)
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8794691 [details]
Bug 1297311: P2. Remove redundant virtual keyword.
https://reviewboard.mozilla.org/r/81008/#review79632
Attachment #8794691 -
Flags: review?(matt.woodrow) → review+
|
||
Comment 4•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8794690 [details]
Bug 1297311: P1. Always recreate a decoder when SPS changes.
https://reviewboard.mozilla.org/r/81006/#review79636
Attachment #8794690 -
Flags: review?(cpearce) → review+
Pushed by jyavenard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/19e901487418
P1. Always recreate a decoder when SPS changes. r=cpearce
https://hg.mozilla.org/integration/autoland/rev/74cc37d7da2c
P2. Remove redundant virtual keyword. r=mattwoodrow
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/19e901487418
https://hg.mozilla.org/mozilla-central/rev/74cc37d7da2c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•