Closed Bug 1300677 Opened 8 years ago Closed 8 years ago

Implement IsHardwareAccelerated and SetSeekThreshold for RemoteVideoDecoder.

Categories

(Core :: Audio/Video: Playback, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- wontfix
firefox52 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(2 files)

Currently these just use the default (empty) implementations, but they are implemented properly for WMF, so we really need them to be implemented over IPC. The latter two just need to be added to PVideoDecoder and hooked up, should be very easy. IsHardwareAccelerated for WMF looks to be racy at the moment, we're not posting a message to the decoder thread (since it's a sync call) and instead just accessing values from the reader task queue directly. It might be best to return the required values in the InitComplete message on PVideoDecoder, and cache them locally in RemoteVideoDecoder. We might need an extra message for the host to send if these values ever change.
Depends on: 1297311
ConfigurationChanged no longer exists.
Summary: Implement IsHardwareAccelerated, ConfigurationChanged and SetSeekThreshold for RemoteVideoDecoder. → Implement IsHardwareAccelerated and SetSeekThreshold for RemoteVideoDecoder.
Attached patch implement-setseekthreshold (deleted) — Splinter Review
Assignee: nobody → matt.woodrow
Attachment #8795953 - Flags: review?(dvander)
Attached patch implement-ishardwareaccelerated (deleted) — Splinter Review
Attachment #8795954 - Flags: review?(dvander)
Attachment #8795953 - Flags: review?(dvander) → review+
Attachment #8795954 - Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3b12b8e293fa Implement SetSeekThreshold for RemoteVideoDecoder. r=dvander https://hg.mozilla.org/integration/mozilla-inbound/rev/4ecfeff44ff5 Implement IsHardwareAccelerated for RemoteVideoDecoder. r=dvander
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: