Closed Bug 1297924 Opened 8 years ago Closed 8 years ago

Update to ANGLE/2845

Categories

(Core :: Graphics: CanvasWebGL, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla51
Tracking Status
firefox50 --- fixed
firefox51 --- fixed

People

(Reporter: jrmuizel, Assigned: mtseng)

References

(Blocks 1 open bug)

Details

Attachments

(6 files, 3 obsolete files)

(deleted), text/x-review-board-request
jgilbert
: review+
Details
(deleted), text/x-review-board-request
jgilbert
: review+
Details
(deleted), text/x-review-board-request
jgilbert
: review+
Details
(deleted), patch
Details | Diff | Splinter Review
(deleted), patch
Details | Diff | Splinter Review
(deleted), patch
Details | Diff | Splinter Review
No description provided.
Blocks: 1212878
Morris is working on this.
Assignee: nobody → mtseng
Attachment #8786200 - Flags: review?(jmuizelaar) → review+
Depends on: 1299055
No longer depends on: 1299055
Depends on: 1299055
Depends on: 1299057
No longer depends on: 1299057
I suggest update to 2845 which include a patch [1] which fix a problem when we using webgl2 on angle. [1]: https://github.com/google/angle/commit/4e58af614176072943bdb302b2395dd85a398514 What do you think, jeff?
Flags: needinfo?(jmuizelaar)
(In reply to Morris Tseng [:mtseng] [:Morris] from comment #15) > I suggest update to 2845 which include a patch [1] which fix a problem when > we using webgl2 on angle. > > [1]: > https://github.com/google/angle/commit/ > 4e58af614176072943bdb302b2395dd85a398514 > > What do you think, jeff? I think that's fine. I tried looking to see how Google handles fixing ANGLE problems on the dev and beta channels and couldn't find any evidence of it happening. Given, that it probably makes sense to track closer to Chrome 55 (to be released Dec 6).
Flags: needinfo?(jmuizelaar)
Summary: Update to ANGLE/2838 → Update to ANGLE/2845
Attachment #8786200 - Attachment is obsolete: true
Attachment #8786201 - Attachment is obsolete: true
Attachment #8786201 - Flags: review?(jgilbert)
Attachment #8786208 - Attachment is obsolete: true
Attachment #8786208 - Flags: review?(jgilbert)
Comment on attachment 8788034 [details] Bug 1297924 - Update shader validator due to interface change. https://reviewboard.mozilla.org/r/76574/#review75272
Attachment #8788034 - Flags: review?(jgilbert) → review+
Attachment #8788035 - Flags: review?(jgilbert) → review+
Attachment #8788033 - Flags: review+
Attachment #8788033 - Flags: review?(jmuizelaar)
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/64a77898c426 Update ANGLE to chromium/2845. r=jgilbert https://hg.mozilla.org/integration/mozilla-inbound/rev/1c9f6480b0e4 Update shader validator due to interface change. r=jgilbert https://hg.mozilla.org/integration/mozilla-inbound/rev/25f7b5f0dee3 Remove passed tests from mochitest-errata. r=jgilbert
Flags: needinfo?(mtseng)
Backout by ihsiao@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9d889e3bc5ba Backed out changeset 25f7b5f0dee3 for webgl test_conformance__textures__misc__copy-tex-image-and-sub-image-2d.html failure https://hg.mozilla.org/integration/mozilla-inbound/rev/a495d31313af Backed out changeset 1c9f6480b0e4 https://hg.mozilla.org/integration/mozilla-inbound/rev/c5ed16e1dbc6 Backed out changeset 64a77898c426
Ahha, our tracked angle repo forgot to add this commit in bug 1290634. Add it and it passed test in my local. Will push a new try later.
Flags: needinfo?(mtseng)
Tracked angle repo also been updated.
Try looks good. Windows 7 VM opt fail is known intermittent.
Pushed by mtseng@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/53735145cfbe Update ANGLE to chromium/2845. r=jgilbert https://hg.mozilla.org/integration/mozilla-inbound/rev/d065b4a4e420 Update shader validator due to interface change. r=jgilbert https://hg.mozilla.org/integration/mozilla-inbound/rev/1c1d78ab773c Remove passed tests from mochitest-errata. r=jgilbert
MozReview-Commit-ID: 90sB4crXQDl
MozReview-Commit-ID: 8VSrUepZsmz
MozReview-Commit-ID: 6OwLEPtdxzA
Comment on attachment 8791074 [details] [diff] [review] Update ANGLE to chromium/2845. r=jgilbert This is dependent patch for bug 1297965, please see bug 1297965 comment 25.
Attachment #8791074 - Flags: approval-mozilla-aurora?
Comment on attachment 8791075 [details] [diff] [review] Update shader validator due to interface change. r=jgilbert This is dependent patch for bug 1297965, please see bug 1297965 comment 25.
Attachment #8791075 - Flags: approval-mozilla-aurora?
Comment on attachment 8791076 [details] [diff] [review] Remove passed tests from mochitest-errata. r=jgilbert This is dependent patch for bug 1297965, please see bug 1297965 comment 25.
Attachment #8791076 - Flags: approval-mozilla-aurora?
Comment on attachment 8791074 [details] [diff] [review] Update ANGLE to chromium/2845. r=jgilbert WebGL2 support, Aurora50+
Attachment #8791074 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8791075 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8791076 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Backed out for Windows 7 test_2_conformance2__reading__read-pixels-pack-parameters.html asserts. https://treeherder.mozilla.org/logviewer.html#?job_id=3562258&repo=mozilla-aurora Assertion failed: mMemoryBuffer.size() > 0, file c:/builds/moz2_slave/m-aurora-w32-d-000000000000000/build/src/gfx/angle/src/libANGLE/renderer/d3d/d3d11/Buffer11.cpp, line 1375 https://hg.mozilla.org/releases/mozilla-aurora/rev/2c332306c030
Flags: needinfo?(mtseng)
Flags: needinfo?(mtseng)
Depends on: 1331335
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: