Closed
Bug 1298410
Opened 8 years ago
Closed 8 years ago
Remove parser support for WebIDL arrays
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
They are not a thing anymore in the spec.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8785339 -
Flags: review?(peterv)
Comment 2•8 years ago
|
||
Comment on attachment 8785339 [details] [diff] [review]
Remove support for IDL arrays, since those are not a thing anymore
Review of attachment 8785339 [details] [diff] [review]:
-----------------------------------------------------------------
::: dom/bindings/parser/WebIDL.py
@@ +4475,5 @@
> 'LegacyCaller',
> base=IDLInterfaceMember.Special
> )
>
> TypeSuffixModifier = enum(
Can't you just remove this enum?
::: dom/bindings/parser/tests/test_arraybuffer.py
@@ +55,5 @@
> harness.ok(attr.type.isSpiderMonkeyInterface(), "Should test as a js interface")
>
> (retType, arguments) = method.signatures()[0]
> harness.ok(retType.isVoid(), "Should have a void return type")
> + harness.check(len(arguments), 3, "Expect 4 arguments")
"Expect 3...
Attachment #8785339 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 3•8 years ago
|
||
> Can't you just remove this enum?
Indeed. Done.
> "Expect 3...
Also done.
Pushed by bzbarsky@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7e5426f358a
Remove support for IDL arrays, since those are not a thing anymore. r=peterv
Comment 5•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•