Closed
Bug 1301015
Opened 8 years ago
Closed 5 years ago
[e10s-multi] Find a real fix for failing tests with multiple content processes
Categories
(Core :: DOM: Content Processes, defect, P3)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: gkrizsanits, Assigned: pbro)
References
Details
(Whiteboard: [e10s-multi:+])
Attachments
(1 file)
For turning turning on 2 content processes on nightly we decided to force some test to run with single content process temporarily. These tests should be modified slightly to support multiple content processes. This is a meta bug to keep around a list of tests where additional work will be needed.
Reporter | ||
Updated•8 years ago
|
Blocks: e10s-multi
Reporter | ||
Updated•8 years ago
|
Whiteboard: [e10s-multi:?]
Reporter | ||
Updated•8 years ago
|
Whiteboard: [e10s-multi:?] → [e10s-multi:M2]
Reporter | ||
Updated•8 years ago
|
Whiteboard: [e10s-multi:M2] → [e10s-multi:?]
Updated•8 years ago
|
Blocks: e10s-multi-aurora
Whiteboard: [e10s-multi:?] → [e10s-multi:+]
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•8 years ago
|
||
As discussed with Gabor on IRC #e10s today, here's a commit that re-enables e10s-multi with some devtools tests.
Try seems happy about this:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a400f2339f744a693a5aa7de919ac6179e31b2c6&group_state=expanded
Note that I didn't change anything to devtools, really just removed the process count pref, which seemed enough. So there must have been fixes in the meantime to made the situation better.
Assignee | ||
Updated•8 years ago
|
Attachment #8849129 -
Flags: review?(gkrizsanits)
Reporter | ||
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8849129 [details]
Bug 1301015 - Re-enable some devtools tests on e10s-multi;
https://reviewboard.mozilla.org/r/121958/#review123942
::: devtools/client/webconsole/test/browser_webconsole_split.js:10
(Diff revision 1)
> function test() {
> waitForExplicitFinish();
> - SpecialPowers.pushPrefEnv({"set": [["dom.ipc.processCount", 1]]}, runTest);
> + runTest();
> }
>
> function runTest() {
> // Test is slow on Linux EC2 instances - Bug 962931
> requestLongerTimeout(2);
Actually here you can just rename |runTest| to |test| move the waitForExplicitFinish there and remove the current |test| function completly. It's no big deal if you don't though, and thanks again for this patch.
Attachment #8849129 -
Flags: review?(gkrizsanits) → review+
Comment hidden (mozreview-request) |
Pushed by pbrosset@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fcbf5460b633
Re-enable some devtools tests on e10s-multi; r=krizsa
Comment 6•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Reporter | ||
Comment 7•8 years ago
|
||
I'm planning to land a few more patches here for the other already working tests.
Reporter | ||
Updated•7 years ago
|
Priority: -- → P2
Comment 8•6 years ago
|
||
Moving to p3 because no activity for at least 1 year(s).
See https://github.com/mozilla/bug-handling/blob/master/policy/triage-bugzilla.md#how-do-you-triage for more information
Priority: P2 → P3
Comment 9•6 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jimm, maybe it's time to close this bug?
Flags: needinfo?(jmathies)
Updated•6 years ago
|
Flags: needinfo?(jmathies)
Comment 10•5 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:jimm, maybe it's time to close this bug?
Flags: needinfo?(jmathies)
Updated•5 years ago
|
Status: REOPENED → RESOLVED
Closed: 8 years ago → 5 years ago
Flags: needinfo?(jmathies)
Resolution: --- → FIXED
Updated•5 years ago
|
Assignee: nobody → pbrosset
Updated•5 years ago
|
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•