Closed Bug 1315042 Opened 8 years ago Closed 4 years ago

[e10s-multi] Re-enable tests after landing e10s-multi on nightly

Categories

(Testing :: General, defect, P2)

Version 3
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: gkrizsanits, Assigned: gkrizsanits)

References

(Blocks 1 open bug)

Details

(Whiteboard: [e10s-multi:+])

We had quite some difficulties with turning all the tests green with 2 content processes enabled, we had to temporarily turn off a few tests in Bug 1301340 as well in the end. Once 2 cp's are enabled on nightly, we want to find a way to turn these tests back on ASAP.
Depends on: 1301340
Some of the tests seem to be fixed by the CPOW leak fix, I have not seen them failing on ash at least and has a green try push with them so I start with those.
Keywords: leave-open
Depends on: 1211098
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/c01643400ac9 Re-disable browser_referrer_middle_click.js because it fails often with e10s enabled. r=bustage-fix on a CLOSED TREE
Needinfo just to track that browser_referrer_middle_click.js got redisabled because of too many failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/c01643400ac9ac36c470c3e6840df098b3ad3f00
Flags: needinfo?(gkrizsanits)
Pushed by kwierso@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/0c46a4a90613 redisable browser_referrer_middle_click_in_container.js for failures a=me
Pushed by kwierso@gmail.com: https://hg.mozilla.org/mozilla-central/rev/ece0e0fd16a3 redisable browser_referrer_middle_click_in_container.js for failures a=me
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/ca140640db89 Re-disable browser_bug719271.js on Windows debug with e10s for frequent failures. r=bustage-fix
Depends on: 1337354
Flags: needinfo?(gkrizsanits)
Depends on: 1337725
Depends on: 1337727
Depends on: 1337728
Depends on: 1337729
Depends on: 1337730
Depends on: 1337731
Depends on: 1337732
Depends on: 1335801
Bug 1301340 forced browser_tabSwitchInPrintPreview.js to run in single-content-process-mode, but I don't see a bug to investigate that and/or remove that workaround, nor any comments in bug 1301340 as to why that was necessary. It's concerning to me that that change was necessary as the test relates to a security issue. Can you clarify if I'm just missing the bug for fixing that test / code properly, or if there isn't one (in which case, please can you file one) ?
Flags: needinfo?(gkrizsanits)
(In reply to :Gijs from comment #15) > Bug 1301340 forced browser_tabSwitchInPrintPreview.js to run in > single-content-process-mode, but I don't see a bug to investigate that > and/or remove that workaround, nor any comments in bug 1301340 as to why > that was necessary. It's concerning to me that that change was necessary as > the test relates to a security issue. Can you clarify if I'm just missing > the bug for fixing that test / code properly, or if there isn't one (in > which case, please can you file one) ? I haven't filed a bug for each of these tests, there is one bug where I plan to fix these issues (bug 1301015). Most of the tests that used to fail with multi and timing related are working now, and there are a few tests where the reason for failure is some kind of anti pattern in the tests and in some cases assumptions about multiple tabs end up in the same content process. I went through most of these tests about a month ago and didn't find anything urgent to fix. That being said I'm going to get to it soon after/during the release as soon as I get time for it. The test you're worried about seem to be working fine locally, and if it failed in a scary way I would have investigated it back then at least, so I'm not too concerned, but feel free to try to reenable multi and push it to try, I expect it to work by now as many others on this list.
Flags: needinfo?(gkrizsanits)
Depends on: 1301015
Whiteboard: [e10s-multi:+]
Priority: -- → P2
The leave-open keyword is there and there is no activity for 6 months. :gbrown, maybe it's time to close this bug?
Flags: needinfo?(gbrown)
I assume we should keep it open for eventual follow-up on disabled tests.
Flags: needinfo?(gbrown)

The leave-open keyword is there and there is no activity for 6 months.
:gbrown, maybe it's time to close this bug?

Flags: needinfo?(gbrown)

Still comment 18?

Flags: needinfo?(gbrown)
Keywords: leave-open
Blocks: e10s-tests

All the dependent bugs are now closed.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Assignee: nobody → gkrizsanits
You need to log in before you can comment on or make changes to this bug.