Closed Bug 1304259 Opened 8 years ago Closed 7 years ago

ESR52: Handle missing checksums.asc file better in sanitize_en_US_binary()

Categories

(Release Engineering :: Release Automation: Other, defect, P3)

Product:
Release Engineering
Component:
Release Automation: Other
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX

People

(Reporter: nthomas, Unassigned)

References

Details

When we can't find a checksums.asc file in the list of artifacts we proceed on to validate_signatures(checksums, signature, tempdir, gpg_key_path) with undefined signature and throw Traceback (most recent call last): File "release-runner.py", line 454, in main File "release-runner.py", line 259, in validate_graph_kwargs sanitize_en_US_binary(queue, task_id, gpg_key_path) File "release-runner.py", line 224, in sanitize_en_US_binary validate_signatures(checksums, signature, tempdir, gpg_key_path) UnboundLocalError: local variable 'signature' referenced before assignment
I remember we've hit this before and it was something on TC side, not necessarily on the sanity logic. But I agree, should rewrite this nicer. The code looks confusing.
Assignee: nobody → mtabara
Planning to work on this at the beginning of Q4. Feel free to reassign if there's someone else volunteering for it in the meantime.
Priority: -- → P2
Assignee: mtabara → nobody
Priority: P2 → P3
We're moving to releaserunner3 for all the things. This should be fixed for Fx59+.
Summary: Handle missing checksums.asc file better in sanitize_en_US_binary() → ESR52: Handle missing checksums.asc file better in sanitize_en_US_binary()
I don't think we should both with this because it's not a common error and only affects ESR52's release runner.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.