Closed
Bug 1305045
Opened 8 years ago
Closed 8 years ago
Make scripts/push_apk.py usable without Mozharness
Categories
(Release Engineering :: Applications: MozharnessCore, defect)
Release Engineering
Applications: MozharnessCore
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
Currently, push_apk.py is a script that depends on mozharness to be executed alone. As we'd like to have APK publishing done in a Taskcluster worker, it'd be preferable to make push_apk.py available in a python package.
Hence, the plan is to take {get,push}_apk.py and update_apk_description.py out in another repo.
Assignee | ||
Comment 1•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Summary: Make scripts/push_apk.py usable from a Python 3 project → Make scripts/push_apk.py usable without Mozharness
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8794294 [details]
PR in new repo
Here's a version without Mozharness what is also compatible with both Python 2 and 3. What's in currently in master is a copy (preserving history) of the scripts from Mozharness. The PR deals with making them mozharness-free.
There is no automated tests yet. As the PR is big enough, I'd like to set that up in a follow up.
I manually tested the 3 main scripts under both pythons. However, because there's no Store L10n for Aurora, I couldn't check the happy path of update_apk_description.py. My credentials don't allow me to perform any change on another product than Aurora. Would you mind checking it Sylvestre?
If the changes are good to you. I'd like to move the repo under mozilla-releng[1] and expose the package to PyPI. That package will be used by [2]
[1] https://github.com/mozilla-releng/
[2] https://github.com/JohanLorenzo/publish-apk-worker
Attachment #8794294 -
Flags: review?(sledru)
Attachment #8794294 -
Flags: review?(aki)
Comment 3•8 years ago
|
||
Comment on attachment 8794294 [details]
PR in new repo
r+ with comments in the PR.
Attachment #8794294 -
Flags: review?(aki) → review+
Assignee | ||
Comment 4•8 years ago
|
||
Sorry for landing before a formal review, Sylvestre. Further development of bug 1286297 is blocked until mozapkpublisher is present on Pypi. I landed the PR in master[1]. I believe the risk of landing it is mitigated by the fact that this repo is not currently used and the old scripts are still available until bug 1305390 lands.
I'll be glad to make improvements in follow ups.
[1] https://github.com/mozilla-releng/mozapkpublisher/commit/7c3ee55f477e2dad0a0bf7d913dee8ced7772b69
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Comment 5•8 years ago
|
||
Comment on attachment 8794294 [details]
PR in new repo
landed!
Attachment #8794294 -
Flags: review?(sledru)
You need to log in
before you can comment on or make changes to this bug.
Description
•