Closed Bug 1306166 Opened 8 years ago Closed 8 years ago

signing task should show up in treeherder

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mozilla, Assigned: kmoir)

References

Details

Attachments

(3 files)

This try push didn't work: we need both the yaml changes and some code in signing.py to actually use it. https://treeherder.mozilla.org/#/jobs?repo=try&revision=bbd1c5e8aacb https://hg.mozilla.org/try/rev/bbd1c5e8aacb04b16c0bb998e2174d059fae0e8e
Assignee: nobody → kmoir
Attached patch bug1306166.patch (deleted) — Splinter Review
Attachment #8801758 - Flags: feedback?(aki)
Attachment #8801758 - Flags: feedback?(aki) → feedback+
Comment on attachment 8801863 [details] [diff] [review] bug1306166th.patch Hm. This makes me wonder if we should rename all the 'linux' as 'linux32'. Not a blocker, though.
Attachment #8801863 - Flags: feedback?(aki) → feedback+
Attached patch bug1306166th2.patch (deleted) — Splinter Review
patch to so signing jobs have same th platform as build job and are co-located on the same line https://treeherder.mozilla.org/#/jobs?repo=try&revision=e20e7db92cf5cf2216ad4128d7b984b31d15bbc5 https://public-artifacts.taskcluster.net/GOncI6ZtTzmn-nPTZEmedg/0/public/full-task-graph.json I fixed the lint error since the try run
Attachment #8801941 - Flags: feedback?(aki)
Comment on attachment 8801941 [details] [diff] [review] bug1306166th2.patch Thanks for working on this! For windows and osx I think it'll be important for signing to happen per CI build, which will allow us to catch signing errors early on instead of at nightly or release time. Having the jobs visible is an important piece to noticing if the jobs are running+succeeding.
Attachment #8801941 - Flags: feedback?(aki) → feedback+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: