Closed Bug 1306718 Opened 8 years ago Closed 8 years ago

Make builds-pending + builds-running use 40 character SHAs for revision

Categories

(Release Engineering :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: emorley, Assigned: emorley)

References

Details

Attachments

(1 file)

Currently they contain: Builds-pending: { "pending": { "try": { "1a855f92cc45": [ { "submitted_at": 1475064907, "id": 125865687, "buildername": "Windows 10 64-bit try debug test mochitest-gl-1" }, Builds-running (whilst the full SHA is under the sub-key, it would be useful to have the top-level key contain the 40 character SHA): { "running": { "autoland": { "cdf154426881": [ { "submitted_at": 1475263520, "buildername": "Android armv7 API 15+ autoland build", "start_time": 1475263723, "number": 320, "claimed_by_name": "buildbot-master74.bb.releng.usw2.mozilla.com:/builds/buildbot/build1/master", "request_ids": [ 126258716 ], "last_heartbeat": 1475264067, "id": 127438343, "revision": "cdf154426881032934224b0ad60bc366afebff41" } ], This blocks some cleanup we're trying to do in Treeherder.
Thank you very much for your help in this and related bugs :-) I'm going on PTO shortly, but will take a look at making some of the changes when I'm back.
Assignee: nobody → emorley
Status: NEW → ASSIGNED
Attachment #8808603 - Flags: review?(nthomas)
Nick, I don't suppose you know when you might get a chance to review this? :-)
Flags: needinfo?(nthomas)
Sorry for the delay. I'll get this reviewed and deployed early next week.
Flags: needinfo?(nthomas)
Comment on attachment 8808603 [details] [diff] [review] [buildapi] Use 40 character revision SHA in builds-(pending|running).js Traced the code paths and they looked as I expected. There's a chance that consumers of this information will have issues, but I think that's mostly treeherder. I'll deploy this Monday my time, please hold off on landing.
Attachment #8808603 - Flags: review?(nthomas) → review+
Many thanks :-)
Comment on attachment 8808603 [details] [diff] [review] [buildapi] Use 40 character revision SHA in builds-(pending|running).js Checked with a version bump in https://hg.mozilla.org/build/buildapi/pushloghtml?changeset=50853ef148fe.
Attachment #8808603 - Flags: checked-in+
Deployment blocked by bug 1318969.
Depends on: 1318969
I tried deploying this using # relengwebadm cd /data/releng/src/buildapi rsync -a virtualenv{,.backup}/ virtualenv/bin/pip install --no-index --find-links=http://pypi.pub.build.mozilla.org/pub/ --trusted-host pypi.pub.build.mozilla.org buildapi==0.3.24 { virtualenv/bin/pip freeze cat production.ini } | md5sum > buildapi.revision /data/releng/deploy buildapi Unfortunately it broke the virtualenv by removing buildapi, and caused a brief tree closure (pending/running state of buildbot jobs wasn't being updated). I restored the backup virtualenv to restore service, so we are still on v0.3.23 until I figure out how the virtualenv got shredded.
I fixed the deployment bug, and pushed v0.3.24 to production. Then noticed that we'd only patched the pending case, so landed https://hg.mozilla.org/build/buildapi/rev/9974107017f9b0605839377e7548d584d05c8e1e to fix running, and deployed v0.3.26. Now we have lovely long revisions for data files https://secure.pub.build.mozilla.org/builddata/buildjson/builds-pending.js https://secure.pub.build.mozilla.org/builddata/buildjson/builds-running.js and human facing pages https://secure.pub.build.mozilla.org/buildapi/pending https://secure.pub.build.mozilla.org/buildapi/running
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Amazing, thank you for fixing the running case too! :-)
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: