Closed Bug 1306986 Opened 8 years ago Closed 8 years ago

Fix occurances of :-moz-locale-dir affecting HTML devtools panels

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Type:
defect

Tracking

(firefox49 unaffected, firefox50 unaffected, firefox51 unaffected, firefox52 wontfix, firefox53 wontfix, firefox54 fix-optional, firefox55 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Tracking Flags:
Tracking Status
firefox49 --- unaffected
firefox50 --- unaffected
firefox51 --- unaffected
firefox52 --- wontfix
firefox53 --- wontfix
firefox54 --- fix-optional
firefox55 --- verified

People

(Reporter: magicp.jp, Assigned: ntim)

References

Details

(Keywords: good-first-bug, Whiteboard: [reserve-html])

Attachments

(2 files)

fix-scrollbutton-up-down-arrow-direction-in-rtl.png
(deleted), image/png
Details
Bug 1306986 - Fix occurances of :-moz-locale-dir affecting HTML devtools panels.
(deleted), text/x-review-board-request
jdescottes
: review+
Details
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Firefox/52.0 Build ID: 20161002030227 Steps to reproduce: 1. Start Nightly in RTL locales (e.g. Arabic) 2. Go to any sites (e.g. about:home) 3. Open DevTools > Inspector 4. Select any elements for displaying scrollbutton-up/down in inspector-breadcrumbs-toolbar Actual results: scrollbutton-up/down arrow direction are reversed. It seems "-moz-locale-dir" pseudo class does not match. Regression range: https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=52cfd2babd94fa8452128940b50614cc12660785&tochange=45513d6773f099db66f0cd7bf1e312f6f9d11475 Expected results: right direction
Blocks: 1305007
Has Regression Range: --- → yes
Has STR: --- → yes
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox51: --- → unaffected
status-firefox52: --- → affected
Component: Untriaged → Developer Tools: Inspector
OS: Unspecified → All
Hardware: Unspecified → All
Assignee: nobody → ntim.bugs
Status: NEW → ASSIGNED
Assignee: ntim.bugs → nobody
Status: ASSIGNED → NEW
Blocks: devtools-html-phase2
Whiteboard: [devtools-html] [triage]
Flags: qe-verify+
Priority: -- → P2
QA Contact: cristian.comorasu
Whiteboard: [devtools-html] [triage] → [devtools-html]
Priority: P2 → P1
Priority: P1 → P3
Whiteboard: [devtools-html] → [reserve-html]
status-firefox53: --- → affected
status-firefox54: --- → affected
Keywords: good-first-bug
Whiteboard: [reserve-html] → [reserve-html][lang=css]
Assignee: nobody → ntim.bugs
Component: Developer Tools: Inspector → Developer Tools
Summary: Fix scrollbutton-up/down arrow direction in RTL locales → Fix occurances of :-moz-locale-dir affecting HTML devtools panels
Whiteboard: [reserve-html][lang=css] → [reserve-html]
Comment on attachment 8851227 [details] Bug 1306986 - Fix occurances of :-moz-locale-dir affecting HTML devtools panels. https://reviewboard.mozilla.org/r/123600/#review126406 Just one small issue for the breadcrumbs widget when used in the old debugger. ::: devtools/client/themes/widgets.css:167 (Diff revision 1) > .scrollbutton-down[disabled] > .toolbarbutton-icon { > opacity: 0.5; > } > > /* Draw shadows to indicate there is more content 'behind' scrollbuttons. */ > -.scrollbutton-up:-moz-locale-dir(ltr), > +.scrollbutton-up:dir(ltr), The old debugger is also using a breadcrumbs widgets and is still in a xul panel. Until the new debugger frontend is enabled in all channel we should keep supporting it.
Attachment #8851227 - Flags: review?(jdescottes) → review+
Mass wontfix for bugs affecting firefox 52.
status-firefox52: affected → wontfix
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/daddaedcf97f Fix occurances of :-moz-locale-dir affecting HTML devtools panels. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/daddaedcf97f
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Not sure if this is worth fixing in beta54, marking fix-optional for now.
status-firefox53: affected → wontfix
status-firefox54: affected → fix-optional
I reproduced this issue using Fx 52.0a1 (build ID: 20161002030227) on Windows 10 x64. I can confirm this issue is fixed, I verified using Fx 55.0a1 (build ID: 20170418030220), on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.11.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Flags: qe-verify+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: