Land support for profiling without any addon in tree
Categories
(Core :: Gecko Profiler, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox69 | --- | fixed |
People
(Reporter: fitzgen, Assigned: gregtatum)
References
(Depends on 1 open bug, Blocks 2 open bugs)
Details
Attachments
(5 files, 2 obsolete files)
Reporter | ||
Updated•8 years ago
|
Assignee | ||
Comment 1•6 years ago
|
||
Might as well use this existing bug. I'm planning on working no landing the Gecko Profiler Addon code in tree, and maintain the mechanism to load profiles in profiler.firefox.com.
Updated•6 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
This bug's first commit will be a non-working revision.
These files are taken from:
Assignee | ||
Comment 3•5 years ago
|
||
Depends on D31547
Assignee | ||
Comment 4•5 years ago
|
||
The WebExtensions do not delete the _addedEventListeners property from
the view node when the widget is destroyed. This stops the widget from
correctly having events dispatched to it, as the initialization code
assumes that it has already been set up.
Depends on D31547
Assignee | ||
Comment 5•5 years ago
|
||
This commit represents the changes needed to convert the existing
Gecko Profiler Add-on code to work outside of the WebExtensions
environment. A following commit will actually wire it into the
rest of the browser.
Depends on D31626
Assignee | ||
Comment 6•5 years ago
|
||
The performance profiler pop-up menu wants to be near DevTools, but work
without the complete DevTools initialization. This patch adds a public
method to perform the initialization code of initializing the provider.
Depends on D31627
Assignee | ||
Comment 7•5 years ago
|
||
This commit takes the popup, and wires it up the button using the
CustomizableUI interface. It is integrated with the DevTools initialization
code.
Depends on D31628
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Comment 8•5 years ago
|
||
Sylvestre/Calixte, could the bot avoid adding back a change it did previously that has been reverted by the bug's assignee?
Comment 9•5 years ago
|
||
The bot is correct here.
If this isn't a meta bug, the meta keyword should be removed. If it is, [meta] should be part of the title (this for the list of bug/search).
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 10•5 years ago
|
||
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Updated•5 years ago
|
Assignee | ||
Comment 11•5 years ago
|
||
Assignee | ||
Comment 12•5 years ago
|
||
Assignee | ||
Comment 13•5 years ago
|
||
Assignee | ||
Comment 14•5 years ago
|
||
Assignee | ||
Comment 15•5 years ago
|
||
Assignee | ||
Comment 16•5 years ago
|
||
This try run changes the strategy to only add the <key>
elements when the menu button is enabled. https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8be4aaa4c51f67384c1c3ea54bb0bbcc6f5c95e
Assignee | ||
Comment 17•5 years ago
|
||
Based on my try run above, the failures I encountered look unrelated to my patch. I recreated the failures locally without my patch on my windows machine, so I'm going to try and land this now.
Comment 18•5 years ago
|
||
Comment 19•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a395d78de549
https://hg.mozilla.org/mozilla-central/rev/2a97b26893c4
https://hg.mozilla.org/mozilla-central/rev/2960e77ad5a6
https://hg.mozilla.org/mozilla-central/rev/020a3fc71e39
https://hg.mozilla.org/mozilla-central/rev/a8a326afa3f8
Updated•5 years ago
|
Comment 20•5 years ago
|
||
I think this is something that should be mentioned in our Nightly Release notes as this is our most technical user base and incitating them to profile pages and report bugs about performance is a worthy. Greg, could you request an addition to the release notes? https://wiki.mozilla.org/Release_Management/Release_Notes#How_to_nominate_a_bug_for_release_notes_addition.3F
Is there some general documentation, screencast or blog post we could link this release note to?
Thanks
Assignee | ||
Comment 21•5 years ago
|
||
I think I'd like 1 more cycle in nightly before releasing information about it. There are still some outstanding usability issues. I will follow-up with information once I fix a few more things.
Description
•