Closed
Bug 1311465
Opened 8 years ago
Closed 8 years ago
Replace uses of django-memoize with django's default cache
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: wlach, Assigned: wlach)
References
Details
Attachments
(1 file)
I used django-memoize for the first pass at caching the bug suggestions, but this doesn't seem like a particularly good fit given the complexity of the caching logic we have for this use case. Let's just switch back to the default django cache to make things easier to reason about.
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8802658 [details]
[treeherder] wlach:1311465 > mozilla:master
I don't think this will fix the problem where we're still hitting the database (or if it does, I'm not sure how it will), but I think it's easier to understand than what we had before.
Attachment #8802658 -
Flags: review?(james)
Updated•8 years ago
|
Attachment #8802658 -
Flags: review?(james) → review+
Assignee | ||
Comment 3•8 years ago
|
||
Morphing bug description to encompass getting rid of django-memoize altogether.
Summary: Use django's cache framework directly for caching bug suggestions → Replace uses of django-memoize with django's default cache
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8802658 [details]
[treeherder] wlach:1311465 > mozilla:master
The expanded scope probably merits a new r?, hopefully the changes are straightforward to review.
Attachment #8802658 -
Flags: review+ → review?(james)
Updated•8 years ago
|
Attachment #8802658 -
Flags: review?(james) → review+
Comment 5•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/e6ef630d8453961ea1ca25abb84aaef54fcccd6f
Bug 1311465 - Replace uses of django-memoize with django's default cache (#1937)
It turns out that django-memoize's behaviour is rather difficult to reason
about for common cases, so let's just use django's cache framework for now.
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•