Closed Bug 131237 Opened 23 years ago Closed 9 years ago

Don't assert at nsStandardURL::SetUserPass during normal HTTP publishing

Categories

(Core :: Networking, defect)

defect
Not set
trivial

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: cmanske, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Use Composer to publish to an HTTP server. Be sure to fill in correct username and password. During nsWebBrowserPersist::CloneNodeWithFixedUpURIAttributes() code path, the password is nulled out as part of normal processing and triggering an assert that is rather annoying!
Severity: normal → trivial
Status: NEW → ASSIGNED
Priority: -- → P5
Target Milestone: --- → mozilla1.0.1
note: the assertion I see is when calling SetUserPass with a file url (which doesn't have a host).
OS: Windows 2000 → All
Hardware: PC → All
brade: no, this one is different. They are both annoying!
Today I don't see any asserts! I am seeing a problem in that even when I supply both username and password, I'm getting the nsIAuth::promptUsernameAndPassword dialog, so the code path may be different.
*** Bug 133980 has been marked as a duplicate of this bug. ***
Target Milestone: mozilla1.0.1 → ---
mass futuring of untargeted bugs
Target Milestone: --- → Future
*** Bug 186715 has been marked as a duplicate of this bug. ***
I'd love to see this assert go away or turned into a warning ... anything that doesn't throw up a dialog everytime it gets hit in a debug win32 build. :-) I have this assert commented out in every debug build I have just so I can use my builds for dogfood and save files.
Attached patch patch (deleted) — Splinter Review
yeah, no need for this assertion if the caller is only clearing the userpass. this patch moves it down.
Attachment #111018 - Flags: superreview?(kin)
Attachment #111018 - Flags: review?(brade)
Attachment #111018 - Flags: review?(brade) → review+
Attachment #111018 - Flags: superreview?(kin) → superreview+
Blocks: 232560
-> default owner
Assignee: darin → nobody
Status: ASSIGNED → NEW
QA Contact: benc → networking
Target Milestone: Future → ---
this code has been updated similarly via some other bug
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: