Closed
Bug 1313290
Opened 8 years ago
Closed 8 years ago
Use browser specific message manager in `SocialShare.sharePage`
Categories
(Firefox Graveyard :: SocialAPI, defect, P1)
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: jryans, Assigned: jryans)
References
Details
(Whiteboard: [multiviewport][reserve-rdm])
Attachments
(1 file)
I noticed that `SocialShare.sharePage` sends several messages to a specific tab's browser with `gBrowser.selectedBrowser.messageManager`, but then waits for a reply using the browser window message manager.
As far as I can tell, it would be safe to listen for a reply on the same message manager used to send. Also, the current version happens to fail to collect page content when the Responsive Design Mode that I am working on for DevTools is used. Switching to the browser specific MM for replies resolves this issue.
Flags: qe-verify-
| Comment hidden (mozreview-request) |
|
Assignee | |
Comment 2•8 years ago
|
||
|
||
Comment 3•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8804995 [details]
Bug 1313290 - Use tab specific MM in SocialShare.sharePage.
https://reviewboard.mozilla.org/r/88800/#review87972
LGTM, assuming tests pass ship it!
Attachment #8804995 -
Flags: review?(mixedpuppy) → review+
|
||
Updated•8 years ago
|
Iteration: --- → 52.3 - Nov 7
|
|
Assignee | |
Comment 4•8 years ago
|
||
Thanks for the quick review!
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6ca6314d95c2
Use tab specific MM in SocialShare.sharePage. r=mixedpuppy
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
||
Updated•6 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•