Closed
Bug 1278762
Opened 8 years ago
Closed 8 years ago
Context menu inside viewport missing actions, not working
Categories
(DevTools :: Responsive Design Mode, defect, P1)
DevTools
Responsive Design Mode
Tracking
(firefox52 verified)
Tracking | Status | |
---|---|---|
firefox52 | --- | verified |
People
(Reporter: jryans, Assigned: jryans)
References
Details
(Whiteboard: [multiviewport][reserve-rdm][qe-rdm])
User Story
Context menu actions should be functional, except for the select / cut / copy / paste actions (which will be handled separately).
Attachments
(7 files)
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
(deleted),
text/x-review-board-request
|
ochameau
:
review+
|
Details |
Comment hidden (obsolete) |
Updated•8 years ago
|
QA Contact: mihai.boldan
Updated•8 years ago
|
Priority: P3 → P2
Assignee | ||
Comment 1•8 years ago
|
||
To clarify, in case someone picks this up while I am on PTO:
* It could be tricky to repair all context menu items, as each one may need specific changes to get it working
* If someone does attempt to repair them, please attempt to do so without changing /browser code like nsContextMenu.js
* If repairing the context menu is too difficult, I think it would be acceptable for now to use a custom context menu for the viewport that has _only_ the "Inspect Element" action (and possibly others if they are working) so at least the broken actions are hidden
Updated•8 years ago
|
Priority: P2 → P1
Updated•8 years ago
|
Priority: P1 → P3
Assignee | ||
Updated•8 years ago
|
Blocks: enable-rdm
Assignee | ||
Comment 2•8 years ago
|
||
I'm attempting to move this forward one way or another.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: P3 → P1
Updated•8 years ago
|
Iteration: --- → 52.3 - Nov 7
Assignee | ||
Updated•8 years ago
|
User Story: (updated)
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 3•8 years ago
|
||
I moved text actions (cut / copy / paste / select all) to bug 1313291 since they are more complex and require a different solution than the other things here.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 11•8 years ago
|
||
Comment 12•8 years ago
|
||
mozreview-review |
Comment on attachment 8804998 [details]
Bug 1278762 - Support spell check context menu actions in RDM.
https://reviewboard.mozilla.org/r/88808/#review88128
Attachment #8804998 -
Flags: review?(poirot.alex) → review+
Comment 13•8 years ago
|
||
mozreview-review |
Comment on attachment 8804999 [details]
Bug 1278762 - Support share this page from context menu in RDM.
https://reviewboard.mozilla.org/r/88810/#review88130
Attachment #8804999 -
Flags: review?(poirot.alex) → review+
Comment 14•8 years ago
|
||
mozreview-review |
Comment on attachment 8805000 [details]
Bug 1278762 - Support general context menu actions in RDM.
https://reviewboard.mozilla.org/r/88812/#review88132
Attachment #8805000 -
Flags: review?(poirot.alex) → review+
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8805001 [details]
Bug 1278762 - Support page info context menu actions in RDM.
https://reviewboard.mozilla.org/r/88814/#review88134
Attachment #8805001 -
Flags: review?(poirot.alex) → review+
Comment 16•8 years ago
|
||
mozreview-review |
Comment on attachment 8805002 [details]
Bug 1278762 - Support view selection source in RDM.
https://reviewboard.mozilla.org/r/88816/#review88136
Attachment #8805002 -
Flags: review?(poirot.alex) → review+
Comment 17•8 years ago
|
||
mozreview-review |
Comment on attachment 8805003 [details]
Bug 1278762 - Support view source in RDM.
https://reviewboard.mozilla.org/r/88818/#review88082
::: devtools/client/responsive.html/browser/tunnel.js:121
(Diff revision 1)
> + get() {
> + return inner.outerWindowID;
> + },
> + configurable: true,
> + enumerable: true,
> + });
I'm lost. Isn't that replacing that other overload?
http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/browser/swap.js#220-227
Comment 18•8 years ago
|
||
mozreview-review |
Comment on attachment 8805004 [details]
Bug 1278762 - Support printing in RDM.
https://reviewboard.mozilla.org/r/88820/#review88138
Attachment #8805004 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 19•8 years ago
|
||
mozreview-review-reply |
Comment on attachment 8805003 [details]
Bug 1278762 - Support view source in RDM.
https://reviewboard.mozilla.org/r/88818/#review88082
> I'm lost. Isn't that replacing that other overload?
> http://searchfox.org/mozilla-central/source/devtools/client/responsive.html/browser/swap.js#220-227
This one exposes the inner `outerWindowID` on the outer browser. The one you linked only adds a getter to the inner browser so that `_outerWindowID` _property_ is accessible as the _getter_ (without underscore).
Comment 20•8 years ago
|
||
mozreview-review |
Comment on attachment 8805003 [details]
Bug 1278762 - Support view source in RDM.
https://reviewboard.mozilla.org/r/88818/#review88148
Attachment #8805003 -
Flags: review?(poirot.alex) → review+
Comment 21•8 years ago
|
||
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/24b223ac858b
Support spell check context menu actions in RDM. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/3a0794bd1c72
Support share this page from context menu in RDM. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/86073e584fa7
Support general context menu actions in RDM. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/13810b9cd717
Support page info context menu actions in RDM. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/4507a959d08b
Support view selection source in RDM. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/b8ee6ceb5e6e
Support view source in RDM. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/a87bd4b96744
Support printing in RDM. r=ochameau
Comment 22•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/24b223ac858b
https://hg.mozilla.org/mozilla-central/rev/3a0794bd1c72
https://hg.mozilla.org/mozilla-central/rev/86073e584fa7
https://hg.mozilla.org/mozilla-central/rev/13810b9cd717
https://hg.mozilla.org/mozilla-central/rev/4507a959d08b
https://hg.mozilla.org/mozilla-central/rev/b8ee6ceb5e6e
https://hg.mozilla.org/mozilla-central/rev/a87bd4b96744
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment 23•8 years ago
|
||
I have reproduced this bug with 50.0a1 (2016-06-07) on Windows 7, 64 Bit !
This bug's fix is verified with latest Nightly
Build ID 20161109030210
User Agent Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0
[bugday-20161109]
Comment 24•8 years ago
|
||
I reproduced this bug using Fx 50.0a1, build ID: 20160607071209, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 52.0a1, build ID: 20161110030211 on Windows 10 x64, Mac OS X 10.11 and Ubuntu 14.04 LTS.
Cheers!
Status: RESOLVED → VERIFIED
Flags: qe-verify+
Whiteboard: [multiviewport][reserve-rdm] → [multiviewport][reserve-rdm][qe-rdm]
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.