Closed
Bug 1313662
Opened 8 years ago
Closed 8 years ago
Force l10n repacks to use simple names, even though build system doesn't support it.
Categories
(Release Engineering :: General, defect)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: Callek, Assigned: Callek)
Details
Attachments
(1 file)
This patch will be against date, since I need to adjust some date logic too.
This is also based ontop of Bug 1312585
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → bugspam.Callek
Assignee | ||
Comment 1•8 years ago
|
||
Testing the to-be-attached patch with https://tools.taskcluster.net/push-inspector/#/Ooq8OCZaS8KNVXcNPUJZtg?_k=tw5jiu and https://tools.taskcluster.net/push-inspector/#/Us7t-SNtTvS1QK7LGI1DHQ?_k=u3oy1t
Comment hidden (mozreview-request) |
Assignee | ||
Comment 3•8 years ago
|
||
r? to aki for mozharness
and r? to dustin for taskcluster/
Comment 4•8 years ago
|
||
mozreview-review |
Comment on attachment 8805537 [details]
Bug 1313662 - Force l10n repacks to use simple names, even though build system doesn't support it.
https://reviewboard.mozilla.org/r/89306/#review88488
I like pink deleted lines :)
Attachment #8805537 -
Flags: review?(dustin) → review+
Comment 5•8 years ago
|
||
mozreview-review |
Comment on attachment 8805537 [details]
Bug 1313662 - Force l10n repacks to use simple names, even though build system doesn't support it.
https://reviewboard.mozilla.org/r/89306/#review88542
As noted in IRC, there are three `# XXX Don't land next line` lines.
I think
a) the comment+next line should be removed, as the comment says, if the next line shouldn't land,
b) the comment should be removed, if we want the next line to stay for the long term, or
c) the comment should be amended, if we want the next line to land but be changed in the nearer term
Thanks for the check to make sure we have one match!
Attachment #8805537 -
Flags: review?(aki) → review+
Comment hidden (mozreview-request) |
Assignee | ||
Comment 7•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 8•8 years ago
|
||
...and I only deleted the XXX from one config, by accident...
https://hg.mozilla.org/projects/date/rev/b8b3192cf5d95181fb9cf54ce9d1ff3611c61537
r=aki over IRC
Updated•7 years ago
|
Component: General Automation → General
You need to log in
before you can comment on or make changes to this bug.
Description
•