Closed
Bug 1314712
Opened 8 years ago
Closed 8 years ago
mozapkpublisher: Prevent single locale APKs from being uploaded
Categories
(Release Engineering :: Release Automation: Other, defect, P2)
Release Engineering
Release Automation: Other
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jlorenzo, Assigned: jlorenzo)
References
Details
Attachments
(1 file)
Let's prevent bug #1314063 from happening again!
:flod told me where we can know if an APK is a multilocale one or not. It's in:
> $APK_PATH:assets/omni.ja:chrome/*
Both the APK and omni.ja are zip files. Chrome contains many folders: some unrelated to locales + 1 per locale. It also has a manifest at the root, explaining how locales are mapped.
I'll use that file to guess how many locales we have and raise errors accordingly.
|
Assignee | |
Updated•8 years ago
|
Summary: mozapkpublisher: Prevent single locales from being uploaded → mozapkpublisher: Prevent single locale APKs from being uploaded
|
|
Assignee | |
Comment 1•8 years ago
|
||
Asking also for feedback from :flod, in order to know if the procedure is strong enough.
I tested the patch manually and it detected 76 languages on an aurora multi-locale, and just 1 on an en-US build. Automated tests will come along [1]
[1] https://github.com/mozilla-releng/mozapkpublisher/pull/3
Attachment #8806833 -
Flags: review?(sledru)
Attachment #8806833 -
Flags: feedback?(francesco.lodolo)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8806833 [details]
PR
The approach makes absolutely sense. Tested and it works as expected.
Attachment #8806833 -
Flags: feedback?(francesco.lodolo) → feedback+
|
||
Updated•8 years ago
|
Attachment #8806833 -
Flags: review?(sledru) → review+
|
||
Updated•8 years ago
|
Priority: -- → P2
|
|
Assignee | |
Comment 3•8 years ago
|
||
Oops, that issue should have been closed a while ago. Landed on master on Nov 7th at: https://github.com/mozilla-releng/mozapkpublisher/commit/a9eee6d804d23181687c2496c0f936db2d349820
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•