Closed
Bug 1315583
Opened 8 years ago
Closed 8 years ago
Release ActiveResourceTracker on the main thread
Categories
(Core :: Graphics: Layers, defect)
Core
Graphics: Layers
Tracking
()
RESOLVED
FIXED
mozilla52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: mattwoodrow, Unassigned)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
ShadowLayerForwarder uses threadsafe refcounting, but ActiveResourceTracker can only be released on the main-thread. Silly.
Attachment #8808024 -
Flags: review?(dvander)
Comment on attachment 8808024 [details] [diff] [review]
release-resource-tracker-main-thread
Review of attachment 8808024 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/layers/ipc/ShadowLayers.cpp
@@ +196,5 @@
> +struct ReleaseOnMainThreadTask : public Runnable
> +{
> + UniquePtr<T> mObj;
> +
> + ReleaseOnMainThreadTask(UniquePtr<T>& aObj)
need "explicit" here to appease the TreeHerder settings
Attachment #8808024 -
Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/62e8c9846f48
Release ActiveResourceTracker on the main thread. r=dvander
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in
before you can comment on or make changes to this bug.
Description
•