I think we have everything we need now for people to start using this, and it looks like it passes try. https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4ed20325077 We'll need to wait until the GPU process is enabled (bug 1314133), and then at least a few days more to make that stabilizes. I think we should run this on Nightly for a bit to make sure it's stable and then we can play with A/B testing to see how much of an impact it has.

Comment on attachment 8807387 [details] [diff] [review] enable-gpu-decoder Review of attachment 8807387 [details] [diff] [review]: ----------------------------------------------------------------- :D

(In reply to Matt Woodrow (:mattwoodrow) from comment #1) > Created attachment 8807387 [details] [diff] [review] > enable-gpu-decoder crash bp-00e35d60-d5a0-40a1-ad3e-6019e2161104

(In reply to Ekanan Ketunuti from comment #3) > (In reply to Matt Woodrow (:mattwoodrow) from comment #1) > > Created attachment 8807387 [details] [diff] [review] > > enable-gpu-decoder > > crash bp-00e35d60-d5a0-40a1-ad3e-6019e2161104 Thanks! That's a really subtle bug with how NS_DISPATCH_SYNC works, I'll fix it.

Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3fc69a00d1a6 Enable OOP video decoding for Nightly builds. r=cpearce

Backed out for crashing various test suites on Windows 8 x64 in e10s mode (except for Marionette which seems to crash without e10s): https://hg.mozilla.org/integration/mozilla-inbound/rev/7ed370dd32f5c20a5ce2f3e1c7fc4a124cf6646d Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=3fc69a00d1a61242dd94cca745b94a46d6d49dd3 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=39129728&repo=mozilla-inbound 03:45:02 INFO - TEST-START | browser/base/content/test/alerts/browser_notification_tab_switching.js 03:45:03 INFO - [GFX1-]: [D3D11] failed to get compositor device. 03:45:03 INFO - [GFX1-]: [D3D11] Failed to init compositor with reason: FEATURE_FAILURE_D3D11_NO_DEVICE 03:45:03 INFO - [GFX1-]: [D3D11] failed to get compositor device. 03:45:03 INFO - [GFX1-]: [D3D11] Failed to init compositor with reason: FEATURE_FAILURE_D3D11_NO_DEVICE 03:45:03 INFO - MEMORY STAT | vsize 685MB | vsizeMaxContiguous 4240094MB | residentFast 260MB | heapAllocated 114MB 03:45:03 INFO - TEST-OK | browser/base/content/test/alerts/browser_notification_tab_switching.js | took 753ms 03:45:03 INFO - checking window state 03:45:04 INFO - Completed ShutdownLeaks collections in process 3616 03:45:05 INFO - Completed ShutdownLeaks collections in process 1084 03:45:05 INFO - TEST-START | Shutdown 03:45:05 INFO - Browser Chrome Test Summary 03:45:05 INFO - Passed: 25 03:45:05 INFO - Failed: 0 03:45:05 INFO - Todo: 0 03:45:05 INFO - Mode: e10s 03:45:05 INFO - *** End BrowserChrome Test Results *** 03:45:06 INFO - TEST-INFO | Main app process: exit 0 03:45:06 INFO - runtests.py | Application ran for: 0:00:22.893000 03:45:06 INFO - zombiecheck | Reading PID log: c:\users\cltbld~1.t-w\appdata\local\temp\tmptt600mpidlog 03:45:06 INFO - ==> process 1084 launched child process 3076 ("C:\slave\test\build\application\firefox\firefox.exe" -contentproc --channel="1084.0.146822970\214158556" -greomni "C:\slave\test\build\application\firefox\omni.ja" -appomni "C:\slave\test\build\application\firefox\browser\omni.ja" -appdir "C:\slave\test\build\application\firefox\browser" 1084 "\\.\pipe\gecko-crash-server-pipe.1084" gpu) 03:45:06 INFO - ==> process 1084 launched child process 3616 ("C:\slave\test\build\application\firefox\firefox.exe" -contentproc --channel="1084.2.67665361\1771560682" -greomni "C:\slave\test\build\application\firefox\omni.ja" -appomni "C:\slave\test\build\application\firefox\browser\omni.ja" -appdir "C:\slave\test\build\application\firefox\browser" 1084 "\\.\pipe\gecko-crash-server-pipe.1084" tab) 03:45:06 INFO - zombiecheck | Checking for orphan process with PID: 3076 03:45:06 INFO - zombiecheck | Checking for orphan process with PID: 3616 03:45:06 INFO - mozcrash Downloading symbols from: https://queue.taskcluster.net/v1/task/VRyKMGSKRqeimJJfVGc4TA/artifacts/public/build/firefox-52.0a1.en-US.win64.crashreporter-symbols.zip 03:45:10 INFO - mozcrash Copy/paste: C:\slave\test\build\win32-minidump_stackwalk.exe c:\users\cltbld~1.t-w\appdata\local\temp\tmpkegbr3.mozrunner\minidumps\cecd6236-5fa4-4831-ac4f-7aa88995cebc.dmp c:\users\cltbld~1.t-w\appdata\local\temp\tmpelxftb 03:45:14 INFO - mozcrash Saved minidump as C:\slave\test\build\blobber_upload_dir\cecd6236-5fa4-4831-ac4f-7aa88995cebc.dmp 03:45:14 INFO - mozcrash Saved app info as C:\slave\test\build\blobber_upload_dir\cecd6236-5fa4-4831-ac4f-7aa88995cebc.extra 03:45:14 INFO - PROCESS-CRASH | Main app process exited normally | application crashed [@ nsTArray_Impl<nsAutoPtr<mozilla::dom::RTCStatsReportInternal>,nsTArrayInfallibleAllocator>::AppendElement<mozilla::dom::RTCStatsReportInternal *,nsTArrayInfallibleAllocator>(mozilla::dom::RTCStatsReportInternal * &&)] 03:45:14 INFO - Crash dump filename: c:\users\cltbld~1.t-w\appdata\local\temp\tmpkegbr3.mozrunner\minidumps\cecd6236-5fa4-4831-ac4f-7aa88995cebc.dmp 03:45:14 INFO - Operating system: Windows NT 03:45:14 INFO - 6.2.9200 03:45:14 INFO - CPU: amd64 03:45:14 INFO - family 6 model 30 stepping 5 03:45:14 INFO - 8 CPUs 03:45:14 INFO - 03:45:14 INFO - GPU: UNKNOWN 03:45:14 INFO - 03:45:14 INFO - Crash reason: EXCEPTION_ACCESS_VIOLATION_READ 03:45:14 INFO - Crash address: 0x0 03:45:14 INFO - Assertion: Unknown assertion type 0x00000000 03:45:14 INFO - Process uptime: 7 seconds 03:45:14 INFO - 03:45:14 INFO - Thread 0 (crashed) 03:45:14 INFO - 0 xul.dll!nsTArray_Impl<nsAutoPtr<mozilla::dom::RTCStatsReportInternal>,nsTArrayInfallibleAllocator>::AppendElement<mozilla::dom::RTCStatsReportInternal *,nsTArrayInfallibleAllocator>(mozilla::dom::RTCStatsReportInternal * &&) [nsTArray.h:3fc69a00d1a6 : 2073 + 0x0] 03:45:14 INFO - rax = 0x0000000000000000 rdx = 0x0000008a5828f1d0 03:45:14 INFO - rcx = 0x0000000000000000 rbx = 0x0000008a5870cfe0 03:45:14 INFO - rsi = 0x000007f9cb22cf38 rdi = 0x000007f9cb7cfb00 03:45:14 INFO - rbp = 0x0000008a5828f330 rsp = 0x0000008a5828f160 03:45:14 INFO - r8 = 0x0000008a5870c000 r9 = 0x0000000000000fe0 03:45:14 INFO - r10 = 0x0000000008000000 r11 = 0x0000008a58600150 03:45:14 INFO - r12 = 0x0000000000000000 r13 = 0x0000000000000000 03:45:14 INFO - r14 = 0x0000008a5871bce0 r15 = 0x0000000000000000 03:45:14 INFO - rip = 0x000007f9c8d1e7d6 03:45:14 INFO - Found by: given as instruction pointer in context 03:45:14 INFO - 1 xul.dll!mozilla::Preferences::AddBoolVarCache(bool *,char const *,bool) [Preferences.cpp:3fc69a00d1a6 : 1776 + 0x1d] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f190 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c873e370 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 2 xul.dll!mozilla::MediaPrefs::MediaPrefs() [MediaPrefs.cpp:3fc69a00d1a6 : 35 + 0x21] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f1d0 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c980ce81 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 3 xul.dll!mozilla::MediaPrefs::GetSingleton() [MediaPrefs.cpp:3fc69a00d1a6 : 21 + 0x16] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f200 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c9820b7a 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 4 xul.dll!mozilla::FindDXVABlacklistedDLL [WMFVideoMFTManager.cpp:3fc69a00d1a6 : 185 + 0xf] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f230 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c98cdd9c 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 5 xul.dll!mozilla::CreateDXVAManagerEvent::Run() [WMFVideoMFTManager.cpp:3fc69a00d1a6 : 315 + 0x21] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f5d0 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c98d12a5 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 6 xul.dll!mozilla::SyncRunnable::Run() [SyncRunnable.h:3fc69a00d1a6 : 110 + 0xa] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f630 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c87024ab 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 7 xul.dll!nsThread::ProcessNextEvent(bool,bool *) [nsThread.cpp:3fc69a00d1a6 : 1216 + 0x9] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f660 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c871bd38 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 8 xul.dll!NS_ProcessNextEvent(nsIThread *,bool) [nsThreadUtils.cpp:3fc69a00d1a6 : 361 + 0xd] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f750 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c873a483 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 9 xul.dll!mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate *) [MessagePump.cpp:3fc69a00d1a6 : 124 + 0xa] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f780 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a53bc0 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 10 xul.dll!mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [MessagePump.cpp:3fc69a00d1a6 : 301 + 0xb] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f7f0 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a53c6b 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 11 xul.dll!MessageLoop::RunHandler() [message_loop.cc:3fc69a00d1a6 : 225 + 0xf] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f820 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a3af67 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 12 xul.dll!MessageLoop::Run() [message_loop.cc:3fc69a00d1a6 : 205 + 0x8] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f850 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a3acfe 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 13 xul.dll!nsBaseAppShell::Run() [nsBaseAppShell.cpp:3fc69a00d1a6 : 156 + 0xd] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f8a0 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c9bfd897 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 14 xul.dll!nsAppShell::Run() [nsAppShell.cpp:3fc69a00d1a6 : 262 + 0x8] 03:45:14 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:14 INFO - rsp = 0x0000008a5828f8d0 r12 = 0x0000000000000000 03:45:14 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:14 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c9c52e91 03:45:14 INFO - Found by: call frame info 03:45:14 INFO - 15 xul.dll!XRE_RunAppShell [nsEmbedFunctions.cpp:3fc69a00d1a6 : 869 + 0x6] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828f900 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f9ca352ecf 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 16 xul.dll!mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate *) [MessagePump.cpp:3fc69a00d1a6 : 269 + 0x5] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828f930 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a53c29 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 17 xul.dll!MessageLoop::RunHandler() [message_loop.cc:3fc69a00d1a6 : 225 + 0xf] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828f960 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a3af67 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 18 xul.dll!MessageLoop::Run() [message_loop.cc:3fc69a00d1a6 : 205 + 0x8] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828f990 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f9c8a3acfe 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 19 xul.dll!XRE_InitChildProcess [nsEmbedFunctions.cpp:3fc69a00d1a6 : 701 + 0x9] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828f9e0 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f9ca352ad6 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 20 firefox.exe!content_process_main(int,char * * const) [plugin-container.cpp:3fc69a00d1a6 : 197 + 0x10] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828fc80 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f6ddab17ad 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 21 firefox.exe!NS_internal_main(int,char * *,char * *) [nsBrowserApp.cpp:3fc69a00d1a6 : 392 + 0xa] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828fcd0 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f6ddab14d1 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 22 firefox.exe!wmain [nsWindowsWMain.cpp:3fc69a00d1a6 : 115 + 0x14] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828fd40 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f6ddab1e63 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 23 firefox.exe!__scrt_common_main_seh [exe_common.inl : 253 + 0x22] 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828fda0 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f6ddad6479 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 24 kernel32.dll!BaseThreadInitThunk + 0x1a 03:45:15 INFO - rbx = 0x0000008a5870cfe0 rbp = 0x0000008a5828f330 03:45:15 INFO - rsp = 0x0000008a5828fde0 r12 = 0x0000000000000000 03:45:15 INFO - r13 = 0x0000000000000000 r14 = 0x0000008a5871bce0 03:45:15 INFO - r15 = 0x0000000000000000 rip = 0x000007f9e67e167e 03:45:15 INFO - Found by: call frame info 03:45:15 INFO - 25 ntdll.dll!RtlUserThreadStart + 0x21 03:45:15 INFO - rsp = 0x0000008a5828fe10 rip = 0x000007f9e8dac3f1 03:45:15 INFO - Found by: stack scanning 03:45:15 INFO - 26 KERNELBASE.dll!GetLegacyComposition + 0x1180 03:45:15 INFO - rsp = 0x0000008a5828fe40 rip = 0x000007f9e5e109d0 03:45:15 INFO - Found by: stack scanning

Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d579376d21b7 Enable OOP video decoding for Nightly builds. r=cpearce

Are we going to enable GPU video decoding in 52 as well? If yes, we should uplift bug 1318999. Otherwise, we should set status-firefox52 to wontfix here and unaffected in bug 1318999.