Closed
Bug 1315818
Opened 8 years ago
Closed 8 years ago
Vagrant: Use localhost instead of local.treeherder.mozilla.org
Categories
(Tree Management :: Treeherder, defect)
Tree Management
Treeherder
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: camd, Assigned: camd)
References
Details
Attachments
(1 file)
We don't need to use a custom domain that requires an entry in etc/hosts. Localhost works fine and is needed for the taskcluster auth transition from Persona.
Assignee | ||
Updated•8 years ago
|
Summary: Vagrant: Use localhost instead of local.treeherder.mozilla.org for vagrant access → Vagrant: Use localhost instead of local.treeherder.mozilla.org
Comment 1•8 years ago
|
||
Assignee | ||
Comment 2•8 years ago
|
||
Comment on attachment 8808403 [details]
[treeherder] mozilla:use-localhost > mozilla:master
We need to at least add localhost support for the Taskcluster auth branch to work.
Attachment #8808403 -
Flags: review?(emorley)
Attachment #8808403 -
Flags: feedback?(wlachance)
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → cdawson
Assignee | ||
Updated•8 years ago
|
Comment 3•8 years ago
|
||
Comment on attachment 8808403 [details]
[treeherder] mozilla:use-localhost > mozilla:master
r+ with the changes mentioned made :-)
After this lands, people will need to either `vagrant reload` to pick up the new new port mappings (preserving the VM), or else `vagrant destroy && vagrant up`.
However until they do that I think their local environment will still work, even when they pick up this comment, since in DEBUG mode, Django doesn't enforce that SITE_URL matches that provided in the host HTTP header.
Attachment #8808403 -
Flags: review?(emorley) → review+
Comment 4•8 years ago
|
||
s/comment/commit/
Updated•8 years ago
|
Comment 6•8 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b37dee233a33949d72673893dea34fdb107bf540
Bug 1315818 - Vagrant: Use localhost instead of local.treeherder.m.o (#1974)
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8808403 [details]
[treeherder] mozilla:use-localhost > mozilla:master
This has been merged
Attachment #8808403 -
Flags: feedback?(wlachance)
Assignee | ||
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•