Closed Bug 1316221 Opened 8 years ago Closed 8 years ago

Make sure we shut down VideoBridge correctly.

Categories

(Core :: Graphics: Layers, defect)

Product:
Core
Component:
Graphics: Layers
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: mattwoodrow, Assigned: mattwoodrow)

References

Details

Attachments

(3 files)

shutdown-video-bridge
(deleted), patch
dvander
: review+
Details | Diff | Splinter Review
Shutdown the video bridge before the compositor thread goes away
(deleted), patch
dvander
: review+
Details | Diff | Splinter Review
Null check mDecoder
(deleted), patch
dvander
: review+
Details | Diff | Splinter Review
Attached patch shutdown-video-bridge (deleted) — — Splinter Review
Looks like I forgot to actually close this, leak tracker caught it.
Attachment #8808897 - Flags: review?(dvander)
Comment on attachment 8808897 [details] [diff] [review] shutdown-video-bridge Review of attachment 8808897 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/layers/ipc/VideoBridgeChild.cpp @@ +34,5 @@ > > } > > VideoBridgeChild::VideoBridgeChild() > + : mIPDLSelfRef(this) It's better to do this in Startup().
Attachment #8808897 - Flags: review?(dvander) → review+
Attached patch Null check mDecoder (deleted) — — Splinter Review
Attachment #8809263 - Flags: review?(dvander)
Attachment #8809262 - Flags: review?(dvander) → review+
Attachment #8809263 - Flags: review?(dvander) → review+
Pushed by mwoodrow@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/46ce017b754c Make sure we call Close on VideoBridgeChild before shutting down. r=dvander https://hg.mozilla.org/integration/mozilla-inbound/rev/474aa8db3223 Force VideoBridge shutdown to happen before the compositor thread is destroyed. r=dvander https://hg.mozilla.org/integration/mozilla-inbound/rev/51c6779de012 Null check mDecoder in RecvShutdown. r=dvander
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: